git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Bradford C Smith <bradford.carl.smith@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] another attempt at make_absolute_path()
Date: Fri, 27 Jul 2007 20:22:30 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707272022090.14781@racer.site> (raw)
In-Reply-To: <11855634561516-git-send-email-bradford.carl.smith@gmail.com>

Hi,

On Fri, 27 Jul 2007, Bradford C Smith wrote:

> Here's my attempt at make_absolute_path() and friends.  I think this
> version handles symlinks cleanly to avoid problems with '..' path
> elements Junio pointed out recently.
> 
> I built these with another patch I previously submitted to make
> git-config consistently use lockfile.c routines and tested it with the
> regular test suite plus some extra tests Junio sent to the list for
> checking git-config symlink handling.
> 
> I also built a separate executable with just the path handling routines
> in it and spot-checked several cases to make sure it appeared to be
> working as expected.  ('/', loop of symlinks, lots of extra slashes, .
> and .. elements, etc.)

Heh.  Just a couple of minutes after I sent my version...

Although I added tests, and you did not...

Ciao,
Dscho

      parent reply	other threads:[~2007-07-27 19:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 19:10 [PATCH 0/2] another attempt at make_absolute_path() Bradford C Smith
2007-07-27 19:10 ` [PATCH 1/2] added file path helper routines Bradford C Smith
2007-07-27 19:10   ` [PATCH 2/2] use make_absolute_path() in lock_file() Bradford C Smith
2007-07-27 19:22 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707272022090.14781@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=bradford.carl.smith@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).