From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sean <seanlkml@sympatico.ca>,
Benoit SIGOURE <tsuna@lrde.epita.fr>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF
Date: Sun, 29 Jul 2007 20:02:21 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707292001580.14781@racer.site> (raw)
In-Reply-To: <7vsl77m4i1.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 29 Jul 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > It is not like the reflog messages have to be very verbose; they only have
> > to give a hint what the commit was about, and the commit name is the
> > important information.
>
> I've considered it, but decided against it because:
>
> (1) I did not like the information lossage;
>
> (2) this is solely to help log messages coming from outside the
> recommended convention, and having excess will not hurt the
> normal usage;
>
> (3) it is not known if messages from outside the recommended
> convention have enough information on its first line of the
> first paragraph; the result of s/\n.*/.../ may not be
> sufficient "hint";
Good catch. Didn't think of that.
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-29 19:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 10:07 git-svn rebase screwing up commit messages Benoit SIGOURE
2007-07-28 12:14 ` Junio C Hamano
2007-07-28 12:35 ` Sean
2007-07-28 13:10 ` Junio C Hamano
2007-07-28 13:29 ` Sean
2007-07-28 13:38 ` Junio C Hamano
2007-07-28 14:11 ` Sean
2007-07-28 20:41 ` Junio C Hamano
2007-07-29 1:08 ` Junio C Hamano
2007-07-29 1:10 ` [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF Junio C Hamano
2007-07-29 11:57 ` Johannes Schindelin
2007-07-29 18:47 ` Junio C Hamano
2007-07-29 19:02 ` Johannes Schindelin [this message]
2007-07-29 1:10 ` [PATCH 2/3] symbolic-ref, update-ref: do not refuse reflog message with LF Junio C Hamano
2007-07-29 1:11 ` [PATCH 3/3] rebase: try not to munge commit log message Junio C Hamano
2007-07-28 14:32 ` git-svn rebase screwing up commit messages Jakub Narebski
2007-07-28 19:48 ` Robin Rosenberg
2007-07-28 17:33 ` Benoit SIGOURE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707292001580.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=seanlkml@sympatico.ca \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).