From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Fix set_work_tree on cygwin
Date: Thu, 2 Aug 2007 16:38:37 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0708021636470.14781@racer.site> (raw)
In-Reply-To: <81b0412b0708020825q4b64c47r3fa1d67858271b1e@mail.gmail.com>
Hi,
On Thu, 2 Aug 2007, Alex Riesen wrote:
>@@ -209,7 +209,8 @@ const char *set_work_tree(const char *dir)
> len = strlen(dir);
> if (len > postfix_len && !strcmp(dir + len - postfix_len,
> "/" DEFAULT_GIT_DIR_ENVIRONMENT)) {
>- strncpy(dir_buffer, dir, len - postfix_len);
>+ strncpy(dir_buffer, dir, len - postfix_len);
>+ dir_buffer[len - postfix_len] = '\0';
>
> /* are we inside the default work tree? */
> rel = get_relative_cwd(buffer, sizeof(buffer), dir_buffer);
Darn, darn, darn. strncpy does _not_ NUL terminate. I keep forgetting
that.
Better use strlcpy()?
Ciao,
Dscho
next prev parent reply other threads:[~2007-08-02 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 15:25 [PATCH] Fix set_work_tree on cygwin Alex Riesen
2007-08-02 15:38 ` Johannes Schindelin [this message]
2007-08-02 20:49 ` Alex Riesen
2007-08-02 21:04 ` Johannes Schindelin
2007-08-02 21:14 ` Junio C Hamano
2007-08-02 21:36 ` Johannes Schindelin
2007-08-02 21:43 ` Junio C Hamano
2007-08-02 22:04 ` [PATCH] Allow setup_work_tree() to be called several times Johannes Schindelin
2007-08-02 22:02 ` [PATCH] Fix unterminated string copy in set_work_tree Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708021636470.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).