From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] Fix quick-install-doc
Date: Sat, 4 Aug 2007 22:32:27 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0708042229130.14781@racer.site> (raw)
In-Reply-To: <46B4BDCF.9060809@gmail.com>
The recent work-tree cleanups exposed that the install-doc-quick
script was relying on a strange behaviour predating the work-tree
series: when setting a GIT_DIR, it was assumed that the current
working directory is the root of the working tree.
The recent work-tree series changed that behaviour: now that you can
set the work tree explicitely, the work tree root defaults to
$GIT_DIR/.. if $GIT_DIR has a /.git suffix when that is a parent
directory of the current working directory.
Noticed by Mark Levedahl. Diagnosed by Junio Hamano.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
Junio, I did it slightly differently from what I said on IRC:
setting the work-tree with "--work-tree" does not work as
expected. Will fix.
Documentation/install-doc-quick.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/install-doc-quick.sh b/Documentation/install-doc-quick.sh
index e6601bd..5c8b604 100755
--- a/Documentation/install-doc-quick.sh
+++ b/Documentation/install-doc-quick.sh
@@ -19,7 +19,7 @@ GIT_INDEX_FILE=`pwd`/.quick-doc.index
export GIT_INDEX_FILE
rm -f "$GIT_INDEX_FILE"
git read-tree $head
-git checkout-index -a -f --prefix="$mandir"/
+(cd "$mandir"; git checkout-index -a -f)
if test -n "$GZ"; then
cd "$mandir"
--
1.5.3.rc4.1.g7805
next prev parent reply other threads:[~2007-08-04 21:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 15:07 rc4 - make quick-install-doc is broken Mark Levedahl
2007-08-04 15:38 ` Johannes Schindelin
2007-08-04 16:00 ` Mark Levedahl
2007-08-04 16:04 ` Johannes Schindelin
2007-08-04 16:14 ` Mark Levedahl
2007-08-04 16:21 ` Johannes Schindelin
2007-08-04 17:56 ` Mark Levedahl
2007-08-04 21:32 ` Johannes Schindelin [this message]
2007-08-04 22:09 ` [PATCH] Fix quick-install-doc René Scharfe
2007-08-05 7:07 ` [PATCH] Fix install-doc-quick target Junio C Hamano
2007-08-05 13:12 ` Johannes Schindelin
2007-08-05 17:54 ` Junio C Hamano
2007-08-05 18:10 ` Johannes Schindelin
2007-08-05 14:44 ` Johannes Schindelin
2007-08-06 22:43 ` [PATCH] (Really) " Mark Levedahl
2007-08-06 22:50 ` Johannes Schindelin
2007-08-06 23:07 ` Junio C Hamano
2007-08-06 23:38 ` Mark Levedahl
2007-08-06 23:43 ` Johannes Schindelin
2007-08-06 23:49 ` Mark Levedahl
2007-08-07 1:28 ` Junio C Hamano
2007-08-07 1:55 ` Mark Levedahl
2007-08-07 3:53 ` Junio C Hamano
2007-08-07 13:55 ` René Scharfe
2007-08-07 14:08 ` Johannes Schindelin
2007-08-04 16:08 ` rc4 - make quick-install-doc is broken Mark Levedahl
2007-08-04 16:16 ` Johannes Schindelin
2007-08-04 16:27 ` Mark Levedahl
2007-08-04 20:19 ` René Scharfe
2007-08-04 20:21 ` Johannes Schindelin
2007-08-04 20:45 ` Mark Levedahl
2007-08-04 21:33 ` Johannes Schindelin
2007-08-04 22:09 ` René Scharfe
2007-08-04 22:25 ` Johannes Schindelin
2007-08-04 22:37 ` Johannes Schindelin
2007-08-04 23:03 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708042229130.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).