git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Wong <normalperson@yhbt.net>,
	Robert Newson <robert.newson@gmail.com>,
	git@vger.kernel.org
Subject: Re: git-svn: Protect against "diff.color = true".
Date: Fri, 31 Aug 2007 22:38:32 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0708312237340.28586@racer.site> (raw)
In-Reply-To: <7v4pifxuia.fsf_-_@gitster.siamese.dyndns.org>

Hi,

On Fri, 31 Aug 2007, Junio C Hamano wrote:

>   I do not have an easy access to SVN repo
>   to interoperate with, so a testing by real-world users and an
>   Ack is appreciated.

I just tested on a busybox clone: Works as expected.  Without your patch, 
I get the uninitialised values, with your patch it is fine.

ACK.

Ciao,
Dscho

  reply	other threads:[~2007-08-31 21:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31 12:58 Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d) Robert Newson
2007-08-31 14:52 ` Junio C Hamano
2007-08-31 15:21   ` Eric Wong
2007-08-31 15:31     ` Robert Newson
2007-08-31 16:09     ` Junio C Hamano
2007-08-31 16:18       ` Robert Newson
2007-08-31 16:25         ` Robert Newson
2007-08-31 16:25         ` Robert Newson
2007-08-31 20:50     ` Junio C Hamano
2007-08-31 21:22       ` Junio C Hamano
2007-08-31 23:47         ` Sam Vilain
2007-08-31 23:51           ` Johannes Schindelin
2007-08-31 21:29       ` git-svn: Protect against "diff.color = true" Junio C Hamano
2007-08-31 21:38         ` Johannes Schindelin [this message]
2007-08-31 21:46           ` Junio C Hamano
2007-08-31 21:53             ` Johannes Schindelin
2007-08-31 22:14               ` Junio C Hamano
2007-08-31 21:58         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0708312237340.28586@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    --cc=robert.newson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).