From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Small cache_tree_write refactor.
Date: Tue, 25 Sep 2007 11:38:16 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709251135530.28395@racer.site> (raw)
In-Reply-To: <20070925082341.DF412BDBCF@madism.org>
Hi,
On Tue, 25 Sep 2007, Pierre Habouzit wrote:
> --- a/cache-tree.c
> +++ b/cache-tree.c
> @@ -369,10 +369,8 @@ int cache_tree_update(struct cache_tree *it,
> return 0;
> }
>
> -static void write_one(struct cache_tree *it,
> - char *path,
> - int pathlen,
> - struct strbuf *buffer)
> +static void write_one(struct strbuf *buffer, struct cache_tree *it,
> + const char *path, int pathlen)
I don't know... is this really needed? In some other projects, the coding
standard prefers the parameters in "in"..."out" order.
Ciao,
Dscho
next prev parent reply other threads:[~2007-09-25 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 8:22 [PATCH] Small cache_tree_write refactor Pierre Habouzit
2007-09-25 10:38 ` Johannes Schindelin [this message]
2007-09-25 11:40 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709251135530.28395@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).