From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Johannes Sixt <johannes.sixt@telecom.at>,
git@vger.kernel.org
Subject: Re: [PATCH] git-commit --amend: respect grafted parents.
Date: Wed, 26 Sep 2007 20:47:49 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709262039250.28395@racer.site> (raw)
In-Reply-To: <7vd4w51csv.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 26 Sep 2007, Junio C Hamano wrote:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>
> > Johannes Schindelin schrieb:
> >> The reason why I insist on not putting this into --amend is that I
> >> think this is not really an amend, but actively a rewrite of the
> >> merge commit.
> >
> > You have a point here. I'm convinced. Scrap the patch.
>
> I am slow today. Since when --amend is not about "a rewrite of commit"?
Technically, you are right, of course. Commit objects are immutable. But
from a _porcelain_ view I maintain that "amending" is about changes _to_ a
commit. It is not about redefining the (a) parent.
Ciao,
Dscho
next prev parent reply other threads:[~2007-09-26 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 12:11 [PATCH] git-commit --amend: respect grafted parents Johannes Sixt
2007-09-26 12:24 ` Johannes Schindelin
2007-09-26 12:52 ` Johannes Sixt
2007-09-26 14:03 ` Johannes Schindelin
2007-09-26 14:29 ` Johannes Sixt
2007-09-26 18:50 ` Junio C Hamano
2007-09-26 19:47 ` Johannes Schindelin [this message]
2007-09-27 8:39 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709262039250.28395@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).