Re: [PATCH/RFT] cvsserver: only allow checkout of branches

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi,

On Thu, 4 Oct 2007, Jan Wielemaker wrote:

> On Thursday 04 October 2007 17:29, Johannes Schindelin wrote:
> > It does not make sense to check out tags or "HEAD".
> >
> > Noticed by Jan Wielemaker.
> 
> Thanks (though it won't bite me a second time :-)

Heh.  But this is Open Source, so we can make it better for others, too.  
Thank you for spending so much time on this, and actually uncovering that 
error in cvsserver!

> > ) +    {
> > +	$log->warn("Checkout failed: $module is not a branch");
> > +	print "error 1 Checkout failed: $module is not a branch\n";
> 
> There are various places where it says print "...", one that even
> started some suggestion on what might be wrong, but these things don't
> end up at a visible place when using ssh as transport. Its a good idea
> this one is at least in the logfile as well. Not sure, but might
> printing to stderr work better?

I think not.  AFAICT stderr is not visible with cvs either.  I somewhat 
hoped that the "error 1" was an indicator to the cvs client to show the 
message, but that's way beyond my knowledge...

Ciao,
Dscho