From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Bernt Hansen <bernt@alumni.uwaterloo.ca>
Subject: Re: [PATCH] Fix in-place editing in crlf_to_git and ident_to_git.
Date: Fri, 5 Oct 2007 09:30:45 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710050930030.4174@racer.site> (raw)
In-Reply-To: <20071005082026.GE19879@artemis.corp>
Hi,
On Fri, 5 Oct 2007, Pierre Habouzit wrote:
> When crlf_to_git or ident_to_git are called "in place", the buffer
> already is big enough and should not be resized (as it could make the
> buffer address change, hence invalidate the `src' pointers !).
I wonder why we resize at all if the buffer is big enough to begin with.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-05 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87wsu2sad0.fsf@gollum.intra.norang.ca>
2007-10-05 8:20 ` [PATCH] Fix in-place editing in crlf_to_git and ident_to_git Pierre Habouzit
2007-10-05 8:11 ` [AGGREGATED PATCH] Fix in-place editing functions in convert.c Pierre Habouzit
2007-10-05 9:24 ` Johannes Sixt
2007-10-05 13:07 ` Bernt Hansen
2007-10-05 15:26 ` Linus Torvalds
2007-10-05 15:50 ` Pierre Habouzit
2007-10-05 16:21 ` Sam Ravnborg
2007-10-05 16:35 ` Pierre Habouzit
2007-10-05 17:25 ` Sam Ravnborg
2007-10-05 16:43 ` Linus Torvalds
2007-10-05 17:24 ` Sam Ravnborg
2007-10-05 18:05 ` Linus Torvalds
2007-10-05 19:27 ` Dmitry Potapov
2007-10-05 19:33 ` Linus Torvalds
2007-10-05 8:27 ` [PATCH] Fix memory leak in apply_filter Pierre Habouzit
2007-10-05 8:29 ` Pierre Habouzit
2007-10-05 8:30 ` Johannes Schindelin [this message]
2007-10-05 8:40 ` [PATCH] Fix in-place editing in crlf_to_git and ident_to_git Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710050930030.4174@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=bernt@alumni.uwaterloo.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).