From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Gerrit Pape <pape@smarden.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-config: respect other options after -l, most notably --file
Date: Tue, 9 Oct 2007 14:15:51 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710091414590.4174@racer.site> (raw)
In-Reply-To: <20071009125024.1259.qmail@d8e601127fe8d0.315fe32.mid.smarden.org>
Hi,
On Tue, 9 Oct 2007, Gerrit Pape wrote:
> @@ -234,6 +235,8 @@ int cmd_config(int argc, const char **argv, const char *prefix)
> argv++;
> }
>
> + if (show_all)
> + return git_config(show_all_config);
> switch (argc) {
> case 2:
> return get_value(argv[1], NULL);
Shouldn't this somehow check if argc == 1 when show_all is set, and die
otherwise?
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-09 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 12:50 [PATCH] git-config: respect other options after -l, most notably --file Gerrit Pape
2007-10-09 13:15 ` Johannes Schindelin [this message]
2007-10-09 22:49 ` Frank Lichtenheld
2007-10-12 11:37 ` [PATCH drop] " Gerrit Pape
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710091414590.4174@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).