From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Frank Lichtenheld <frank@lichtenheld.de>
Cc: gitster@pobox.com, hjemli@gmail.com,
Jan Wielemaker <wielemak@science.uva.nl>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Support cvs via git-shell
Date: Wed, 10 Oct 2007 14:29:00 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710101427160.4174@racer.site> (raw)
In-Reply-To: <20071009223538.GG31659@planck.djpig.de>
Hi,
On Wed, 10 Oct 2007, Frank Lichtenheld wrote:
> On Tue, Oct 09, 2007 at 03:33:25PM +0100, Johannes Schindelin wrote:
> > static struct commands {
> > const char *name;
> > int (*exec)(const char *me, char *arg);
> > } cmd_list[] = {
> > { "git-receive-pack", do_generic_cmd },
> > { "git-upload-pack", do_generic_cmd },
> > + { "cvs", do_cvs_cmd },
> > { NULL },
>
> Maybe this should also allow git-cvsserver for completeness' sake?
Umm. Why?
If you use a cvs client with :ext: protocol, it will call ssh (or rsh!)
with the command "cvs server", not "git-cvsserver".
Only in setups where you set (IIRC) the environment variable "CVSSERVER"
on the client to "git-cvsserver" will it call something different, but
these setups exist already, and never used git-shell to begin with.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-10 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 12:53 [PATCH] git-shell and git-cvsserver Jan Wielemaker
2007-10-05 14:31 ` Miklos Vajna
2007-10-05 15:07 ` Frank Lichtenheld
2007-10-08 4:51 ` Johannes Schindelin
2007-10-08 14:22 ` Jan Wielemaker
2007-10-09 11:51 ` Johannes Schindelin
2007-10-09 14:33 ` [PATCH] Support cvs via git-shell Johannes Schindelin
2007-10-09 22:35 ` Frank Lichtenheld
2007-10-10 13:29 ` Johannes Schindelin [this message]
2007-10-10 19:10 ` Frank Lichtenheld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710101427160.4174@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=wielemak@science.uva.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).