From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Jonathan del Strother <maillist@steelskies.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Adding color to git-add--interactive
Date: Wed, 10 Oct 2007 16:06:09 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710101604350.4174@racer.site> (raw)
In-Reply-To: <20071009234020.GA20952@coredump.intra.peff.net>
Hi,
On Tue, 9 Oct 2007, Jeff King wrote:
> On Tue, Oct 09, 2007 at 02:06:31PM +0100, Jonathan del Strother wrote:
>
> > For me at least, adding color would make the interactive mode far more
> > readable. I hacked in basic color support (just coloring PROMPT &
> > HEADER in list_and_choose, and the "Stage this hunk?" prompt) - which
> > helped a lot - but then reached the limits of my perl knowledge. For
> > instance, I can't see a sensible way of reusing git-svn's
> > log_use_color function without importing the entire file, and I can't
> > figure out how you'd go about diff-coloring the hunks. Is anyone with
> > more perl knowledge than me interested in taking this on?
>
> Why don't you post what you have, and we can make comments on it?
>
> As far as reusing code from git-svn, there is a 'Git.pm' module in the
> perl/ subdirectory. You can move the code there and 'use Git' in
> git-add--interactive.perl (git-svn already uses it).
I think the reason git-add--interactive does not use it is that some
people (me included) experienced heavy problems with perl modules.
However, I do not recall to which extent they have been solved. I guess
when git-add--interactive goes Git.pm and stops working for me, I'll do my
famous "aargh, I'll just make it a builtin" song.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-10 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 13:06 Adding color to git-add--interactive Jonathan del Strother
2007-10-09 13:31 ` Wincent Colaiuta
2007-10-09 14:04 ` Johannes Schindelin
2007-10-09 14:44 ` Wincent Colaiuta
2007-10-09 23:40 ` Jeff King
2007-10-10 15:06 ` Johannes Schindelin [this message]
2007-10-10 17:06 ` Jeff King
2007-10-10 21:09 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710101604350.4174@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=maillist@steelskies.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).