git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Steffen Prohaska <prohaska@zib.de>
Cc: spearce@spearce.org, git@vger.kernel.org
Subject: Re: [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit
Date: Wed, 10 Oct 2007 20:46:06 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0710102044220.4174@racer.site> (raw)
In-Reply-To: <CC4EB4CA-3BA0-4C00-8B23-31B09032CC69@zib.de>

Hi,

On Wed, 10 Oct 2007, Steffen Prohaska wrote:

> On Oct 10, 2007, at 5:52 PM, Johannes Schindelin wrote:
> 
> > On Wed, 10 Oct 2007, Steffen Prohaska wrote:
> > 
> > > Shawn's git-gui Makefile supports the pure tcl replacement for 
> > > msgfmt if setting NO_MSGFMT. This patch sets the NO_MSGFMT for 
> > > msysgit.
> > 
> > Would it not be cleaner to set this in 4msysgit and export it?
> 
> What does "set this in 4msysgit" mean?

It means what you probably assumed, that we change the Makefile in /git.

> Would running 'make' in /git/git-gui/ be supported by your solution?

No, not really.  Just like "make" in /git/t/ does not pick up on the 
NO_SYMLINKS option.

Ciao,
Dscho

      reply	other threads:[~2007-10-10 19:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071010053728.GM2137@spearce.org>
2007-10-10  5:56 ` [PATCH] git-gui: add mingw specific startup wrapper Steffen Prohaska
2007-10-10  6:22   ` Shawn O. Pearce
2007-10-10  6:55     ` Steffen Prohaska
2007-10-10  6:58       ` [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit Steffen Prohaska
2007-10-10  6:58         ` [PATCH v2] git-gui: add mingw specific startup wrapper Steffen Prohaska
2007-10-10  8:02           ` Shawn O. Pearce
2007-10-10 15:56           ` Johannes Schindelin
2007-10-10 16:10             ` Steffen Prohaska
2007-10-10 15:52         ` [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit Johannes Schindelin
2007-10-10 15:58           ` Steffen Prohaska
2007-10-10 19:46             ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0710102044220.4174@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=prohaska@zib.de \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).