From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Lars Hjemli <hjemli@gmail.com>
Cc: Han-Wen Nienhuys <hanwenn@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-branch: only traverse the requested refs
Date: Thu, 11 Oct 2007 00:00:08 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710102358110.4174@racer.site> (raw)
In-Reply-To: <1192053283-2351-1-git-send-email-hjemli@gmail.com>
Hi,
On Wed, 10 Oct 2007, Lars Hjemli wrote:
> This avoids looking at every single file below .git/refs when git-branch
> is fetching the list of refs to display.
>
> [...]
>
> + if (kinds & REF_LOCAL_BRANCH) {
> + ref_list.kinds = REF_LOCAL_BRANCH;
> + for_each_branch_ref(append_ref, &ref_list);
> + }
The function for_each_branch_ref() calls do_for_each_ref(), which in turn
calls get_loose_refs(), which calls get_ref_dir() to read all loose refs,
if they have not yet been read.
So I think that your patch (unfortunately) will no help Han-Wen's
situation.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-10 23:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 20:22 git branch performance problem? Han-Wen Nienhuys
2007-10-10 20:44 ` Lars Hjemli
2007-10-10 21:17 ` Han-Wen Nienhuys
2007-10-10 21:24 ` Han-Wen Nienhuys
2007-10-10 21:30 ` Han-Wen Nienhuys
2007-10-10 21:39 ` J. Bruce Fields
2007-10-10 21:45 ` Lars Hjemli
2007-10-10 21:49 ` Han-Wen Nienhuys
2007-10-10 21:53 ` J. Bruce Fields
2007-10-10 22:01 ` Han-Wen Nienhuys
2007-10-10 21:53 ` Johannes Schindelin
2007-10-10 22:55 ` Spam: " Brandon Casey
2007-10-11 9:41 ` Mike Ralphson
2007-10-11 10:58 ` Johannes Schindelin
2007-10-10 23:39 ` Linus Torvalds
2007-10-11 2:26 ` Han-Wen Nienhuys
2007-10-11 6:41 ` Alex Riesen
2007-10-11 10:46 ` Johannes Schindelin
2007-10-11 13:11 ` Han-Wen Nienhuys
2007-10-11 15:16 ` Linus Torvalds
2007-10-12 17:19 ` Salikh Zakirov
2007-10-10 21:34 ` Lars Hjemli
2007-10-10 21:54 ` [PATCH] git-branch: only traverse the requested refs Lars Hjemli
2007-10-10 23:00 ` Johannes Schindelin [this message]
2007-10-10 23:30 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710102358110.4174@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwenn@gmail.com \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).