git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Gerrit Pape <pape@smarden.org>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH amend] git-config: handle --file option with relative pathname properly
Date: Fri, 12 Oct 2007 13:08:57 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0710121308040.25221@racer.site> (raw)
In-Reply-To: <20071012113251.29941.qmail@7584201f340355.315fe32.mid.smarden.org>

Hi,

On Fri, 12 Oct 2007, Gerrit Pape wrote:

> -	setup_git_directory_gently(&nongit);
> +	const char *file = setup_git_directory_gently(&nongit);

One last nit (because I did not see it earlier): please call the variable 
"prefix", not "file".

Other than that, I think your patch is obviously correct.

Thanks,
Dscho

      reply	other threads:[~2007-10-12 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09 12:49 [PATCH] git-config: handle --file option with relative pathname properly Gerrit Pape
2007-10-09 13:14 ` Johannes Schindelin
2007-10-09 13:20 ` Johannes Sixt
2007-10-12 11:32   ` [PATCH amend] " Gerrit Pape
2007-10-12 12:08     ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0710121308040.25221@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=pape@smarden.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).