From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 5/7] Bisect: factorise some logging into "bisect_write".
Date: Sun, 14 Oct 2007 17:07:46 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710141706440.25221@racer.site> (raw)
In-Reply-To: <20071014142948.9f08b8ed.chriscool@tuxfamily.org>
Hi,
On Sun, 14 Oct 2007, Christian Couder wrote:
> diff --git a/git-bisect.sh b/git-bisect.sh
> index 847250c..e12125f 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -132,6 +131,7 @@ bisect_write() {
> esac
> echo "$rev" >"$GIT_DIR/refs/bisect/$tag"
> echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
> + test -z "$nolog" && echo "git-bisect $state $rev" >>"$GIT_DIR/BISECT_LOG"
> }
Isn't a nolog="$3" missing from bisect_write()?
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-14 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 12:29 [PATCH 5/7] Bisect: factorise some logging into "bisect_write" Christian Couder
2007-10-14 16:07 ` Johannes Schindelin [this message]
2007-10-14 22:40 ` Lars Hjemli
2007-10-15 3:35 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710141706440.25221@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).