From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 01/14] Change git_connect() to return a struct child_process
 instead of a pid_t.
Date: Sun, 14 Oct 2007 18:10:22 +0100 (BST)
Message-ID: <Pine.LNX.4.64.0710141810020.25221@racer.site>
References: <1192305984-22594-1-git-send-email-johannes.sixt@telecom.at>
 <1192305984-22594-2-git-send-email-johannes.sixt@telecom.at>
 <Pine.LNX.4.64.0710140156100.25221@racer.site> <200710141140.10597.johannes.sixt@telecom.at>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: git@vger.kernel.org, gitster@pobox.com
To: Johannes Sixt <johannes.sixt@telecom.at>
X-From: git-owner@vger.kernel.org Sun Oct 14 19:11:17 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1Ih6za-0008De-L9
	for gcvg-git-2@gmane.org; Sun, 14 Oct 2007 19:11:07 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758734AbXJNRKa (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sun, 14 Oct 2007 13:10:30 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758254AbXJNRKa
	(ORCPT <rfc822;git-outgoing>); Sun, 14 Oct 2007 13:10:30 -0400
Received: from mail.gmx.net ([213.165.64.20]:35391 "HELO mail.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1758712AbXJNRK2 (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 14 Oct 2007 13:10:28 -0400
Received: (qmail invoked by alias); 14 Oct 2007 17:10:26 -0000
Received: from wbgn013.biozentrum.uni-wuerzburg.de (EHLO openvpn-client) [132.187.25.13]
  by mail.gmx.net (mp003) with SMTP; 14 Oct 2007 19:10:26 +0200
X-Authenticated: #1490710
X-Provags-ID: V01U2FsdGVkX19aCEUvyWxaMEUT/gIt9SvqrYYDqmJSJhmK44dzNO
	pomnZISobF7Pyd
X-X-Sender: gene099@racer.site
In-Reply-To: <200710141140.10597.johannes.sixt@telecom.at>
X-Y-GMX-Trusted: 0
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/60872>

Hi,

On Sun, 14 Oct 2007, Johannes Sixt wrote:

> On Sunday 14 October 2007 02:57, Johannes Schindelin wrote:
> >
> > On Sat, 13 Oct 2007, Johannes Sixt wrote:
> > > -int finish_connect(pid_t pid)
> > > +int finish_connect(struct child_process *conn)
> > >  {
> > > -	if (pid == 0)
> > > +	if (conn == NULL)
> > >  		return 0;
> > >
> > > -	while (waitpid(pid, NULL, 0) < 0) {
> > > +	while (waitpid(conn->pid, NULL, 0) < 0) {
> > >  		if (errno != EINTR)
> > >  			return -1;
> >
> > Just for completeness' sake: could you do a free(conn); before return 
> > -1;?
> 
> I know. But the loop is going away with the next patch, so I didn't 
> bother. Can you live with that?

It'll be hard, but I'll try ;-)

Ciao,
Dscho