From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Scott R Parish <srp@srparish.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] "git help -a" should search all exec_paths and PATH
Date: Sun, 21 Oct 2007 23:25:29 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710212323580.25221@racer.site> (raw)
In-Reply-To: <20071021214846.GI16291@srparish.net>
Hi,
On Sun, 21 Oct 2007, Scott R Parish wrote:
> Currently "git help -a" only searches in the highest priority exec_path,
> meaning at worst, nothing is listed if the git commands are only
> available from the PATH. It also makes git slightly less extensible.
>
> To fix this, help.c is modified to search in all the exec_paths and PATH
> for potential git commands.
With this explanation, I would have expected that you add a loop just like
in exec-cmd.c. Not anything more. And certainly not the removal of a
sanity check for the length of the path name.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-21 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 21:48 [PATCH] "git help -a" should search all exec_paths and PATH Scott R Parish
2007-10-21 22:25 ` Johannes Schindelin [this message]
2007-10-22 0:54 ` Scott Parish
2007-10-22 5:30 ` Shawn O. Pearce
2007-10-22 6:32 ` Scott Parish
2007-10-22 6:39 ` Shawn O. Pearce
2007-10-22 6:06 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710212323580.25221@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=srp@srparish.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).