From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Andreas Ericsson <ae@op5.se>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] git-format-patch: Don't number patches when there's only one
Date: Mon, 22 Oct 2007 10:44:12 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710221044080.25221@racer.site> (raw)
In-Reply-To: <20071021144637.762085BB92@nox.op5.se>
Hi,
On Sun, 21 Oct 2007, Andreas Ericsson wrote:
> [PATCH 1/1] looks a bit silly, and automagically handling this in
> git-format-patch makes some scripting around it a lot more pleasant.
I think you should not use "-n" if you do not want to have the numbers.
In circumstances as yours, where you can have patch series larger than
one, I imagine that the "[PATCH 1/1]" bears an important information,
which is not present in "[PATCH]": this patch series contains only one
patch.
IOW I do not like your patch: too much DWIDNS (Do What I Did NOT Say) for
me.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-22 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 8:13 [PATCH] git-format-patch: Don't number patches when there's only one Andreas Ericsson
2007-10-22 9:44 ` Johannes Schindelin [this message]
2007-10-22 10:14 ` Andreas Ericsson
2007-10-22 10:22 ` Johannes Schindelin
2007-10-22 11:13 ` Andreas Ericsson
2007-11-03 15:44 ` [PATCH] git-format-patch: Number patches when there are more than one Mike Hommey
2007-11-03 15:59 ` Andreas Ericsson
2007-11-03 16:03 ` Mike Hommey
2007-11-03 16:32 ` Andreas Ericsson
2007-11-03 18:56 ` Samuel Tardieu
2007-11-03 16:31 ` Johannes Schindelin
2007-11-03 16:34 ` Andreas Ericsson
2007-11-04 0:25 ` Johannes Schindelin
2007-11-04 9:49 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710221044080.25221@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).