From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Add color to git-add--interactive diffs (Total different
 idea to solve the problem)
Date: Tue, 23 Oct 2007 00:55:44 +0100 (BST)
Message-ID: <Pine.LNX.4.64.0710230054130.25221@racer.site>
References: <1192351494.7226.18.camel@athena> <20071022204719.GA23348@xp.machine.xx>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Tom Tobin <korpios@korpios.com>, Dan Zwell <dzwell@gmail.com>,
	Jonathan del Strother <maillist@steelskies.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Git Mailing List <git@vger.kernel.org>
To: Peter Baumann <waste.manager@gmx.de>
X-From: git-owner@vger.kernel.org Tue Oct 23 01:56:26 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1Ik78D-0001I4-6R
	for gcvg-git-2@gmane.org; Tue, 23 Oct 2007 01:56:25 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751029AbXJVX4L (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Mon, 22 Oct 2007 19:56:11 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750798AbXJVX4L
	(ORCPT <rfc822;git-outgoing>); Mon, 22 Oct 2007 19:56:11 -0400
Received: from mail.gmx.net ([213.165.64.20]:56323 "HELO mail.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1750703AbXJVX4K (ORCPT <rfc822;git@vger.kernel.org>);
	Mon, 22 Oct 2007 19:56:10 -0400
Received: (qmail invoked by alias); 22 Oct 2007 23:56:08 -0000
Received: from wbgn013.biozentrum.uni-wuerzburg.de (EHLO openvpn-client) [132.187.25.13]
  by mail.gmx.net (mp004) with SMTP; 23 Oct 2007 01:56:08 +0200
X-Authenticated: #1490710
X-Provags-ID: V01U2FsdGVkX190TvxDV8t0BkC0iElIv2G6+K3FUFfxxLVvTiCvZ6
	+o5X2n9ittTgef
X-X-Sender: gene099@racer.site
In-Reply-To: <20071022204719.GA23348@xp.machine.xx>
X-Y-GMX-Trusted: 0
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/62061>

Hi,

On Mon, 22 Oct 2007, Peter Baumann wrote:

> Wouldn't it make more sense to implement the diff coloring inside git 
> apply so that you could use something like
> 
>         diff file1 file2|git apply --color
> 
> to make the generated diff with colors [1]? It already implements the
> same semantic for generating a diffstat, using
> 
>         diff file1 file2|git apply --stat

No.  In both cases, "git diff" realises that the output is no terminal, 
and switches off color generation.  (Just try with diff.color=true instead 
of =auto.)

Ciao,
Dscho