git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add test case for running from a subdirectory with GIT_WORK_TREE
Date: Sat, 27 Oct 2007 13:45:23 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0710271343270.4362@racer.site> (raw)
In-Reply-To: <20071027081954.GA23406@laptop>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 668 bytes --]

Hi,

On Sat, 27 Oct 2007, Nguyễn Thái Ngọc Duy wrote:

> +mkdir -p work/sub/dir || exit 1
> +mv .git work
> +if test "$1" = --normal; then
> +	say "Normal case"
> +else
> +	say "Worktree case"
> +fi
> +test "$1" = --normal || mv work/.git repo.git || exit 1
> +
> +test "$1" = --normal || export GIT_DIR=$(pwd)/repo.git
> +export GIT_CONFIG="$(pwd)"/$GIT_DIR/config
> +test "$1" = --normal || export GIT_WORK_TREE=$(pwd)/work
> +
> +cd work/sub || exit 1

Why don't you put this block into a test_expect_success?  And then just 
make a

	for mode in normal worktree
	do

	...

	done

Hmm?  I would like to see this test case in the official git.git.

Ciao,
Dscho

  reply	other threads:[~2007-10-27 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-27  8:19 [PATCH] Add test case for running from a subdirectory with GIT_WORK_TREE Nguyễn Thái Ngọc Duy
2007-10-27 12:45 ` Johannes Schindelin [this message]
     [not found]   ` <fcaeb9bf0710270557n48a01ba2w3a89f65680b946d@mail.gmail.com>
2007-10-27 13:27     ` Johannes Schindelin
2007-10-28  0:18   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0710271343270.4362@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).