git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Minor inconsistency: "git tag" requires space after -m.
@ 2007-10-27 11:55 Sergei Organov
  2007-10-27 12:48 ` Johannes Schindelin
  0 siblings, 1 reply; 3+ messages in thread
From: Sergei Organov @ 2007-10-27 11:55 UTC (permalink / raw)
  To: git

Hello,

It seems options parsing is somewhat broken in git-tag:

$ git tag -a -m"Annotated tag" annotated-tag
usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
$ git tag -a -m "Annotated tag" annotated-tag
$ git --version
git version 1.5.3.4

This is inconsistent with, say, "git commit", that groks -m"Message"
(without space after -m) just fine.

-- 
Sergei.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Minor inconsistency: "git tag" requires space after -m.
  2007-10-27 11:55 Minor inconsistency: "git tag" requires space after -m Sergei Organov
@ 2007-10-27 12:48 ` Johannes Schindelin
  2007-10-27 13:14   ` Sergei Organov
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2007-10-27 12:48 UTC (permalink / raw)
  To: Sergei Organov; +Cc: git

Hi,

On Sat, 27 Oct 2007, Sergei Organov wrote:

> It seems options parsing is somewhat broken in git-tag:
> 
> $ git tag -a -m"Annotated tag" annotated-tag
> usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
> $ git tag -a -m "Annotated tag" annotated-tag
> $ git --version
> git version 1.5.3.4
> 
> This is inconsistent with, say, "git commit", that groks -m"Message"
> (without space after -m) just fine.

As it happens, we are in the middle of adding our own option parser which 
probably solves the issue.  Can you please retest when we have that, and 
use it in builtin-tag?

Thanks,
Dscho

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Minor inconsistency: "git tag" requires space after -m.
  2007-10-27 12:48 ` Johannes Schindelin
@ 2007-10-27 13:14   ` Sergei Organov
  0 siblings, 0 replies; 3+ messages in thread
From: Sergei Organov @ 2007-10-27 13:14 UTC (permalink / raw)
  To: git

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi,
>
> On Sat, 27 Oct 2007, Sergei Organov wrote:
>
>> It seems options parsing is somewhat broken in git-tag:
>> 
>> $ git tag -a -m"Annotated tag" annotated-tag
>> usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
>> $ git tag -a -m "Annotated tag" annotated-tag
>> $ git --version
>> git version 1.5.3.4
>> 
>> This is inconsistent with, say, "git commit", that groks -m"Message"
>> (without space after -m) just fine.
>
> As it happens, we are in the middle of adding our own option parser which 
> probably solves the issue.  Can you please retest when we have that, and 
> use it in builtin-tag?

I'm 100% sure there will be no inconsistencies once you unify options
parsing among the tools, but I won't refrain from re-testing this
anyway.

-- 
Sergei.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-10-27 13:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-27 11:55 Minor inconsistency: "git tag" requires space after -m Sergei Organov
2007-10-27 12:48 ` Johannes Schindelin
2007-10-27 13:14   ` Sergei Organov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).