From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Mike Hommey <mh@glandium.org>, git@vger.kernel.org
Subject: Re: [PATCH] Don't use cpio in git-clone when not installed
Date: Wed, 31 Oct 2007 23:55:58 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0710312354180.4362@racer.site> (raw)
In-Reply-To: <7v4pg6hq8u.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 31 Oct 2007, Junio C Hamano wrote:
> "type"? That's probably better than using "which", but sounds quite
> wrong. Why not add Makefile target that the shell scripts depend on to
> see if necessary tools are available and let the builder know if they
> are not?
I thought the accord was that "cpio" is a _runtime_ dependency. But yes,
I agree "type" is not necessarily the best choice. Maybe testing the exit
code for 127 (not found) is the better choice?
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-31 23:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 20:05 [PATCH] Don't use cpio in git-clone when not installed Mike Hommey
2007-10-31 20:10 ` Mike Hommey
2007-10-31 22:29 ` Junio C Hamano
2007-10-31 23:55 ` Johannes Schindelin [this message]
2007-11-01 0:46 ` Linus Torvalds
2007-11-01 1:00 ` Jakub Narebski
2007-11-01 1:05 ` Nguyen Thai Ngoc Duy
2007-11-01 1:12 ` Junio C Hamano
2007-11-01 6:31 ` Mike Hommey
2007-11-01 13:06 ` Alexander Skwar
2007-11-01 1:09 ` Nguyen Thai Ngoc Duy
2007-11-01 1:15 ` Junio C Hamano
2007-11-01 1:25 ` Nguyen Thai Ngoc Duy
2007-11-01 6:45 ` Junio C Hamano
2007-11-01 10:53 ` Mike Hommey
2007-11-01 21:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710312354180.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).