Re: [PATCH] Document that using -M without other diff options is not a good idea

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi,

On Thu, 1 Nov 2007, Miklos Vajna wrote:

> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
> 
> I just noticed that I used 'git log -M' in some scripts which is obviously bad.
> People should not use that option without other diff options.
> 
>  Documentation/diff-options.txt |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index b1f528a..ed827f8 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -92,7 +92,9 @@
>  	Break complete rewrite changes into pairs of delete and create.
>  
>  -M::
> -	Detect renames.
> +	Detect renames. It's no good using this option if you don't use diff
> +	options like `--name-status`, `-p` or `--stat` as it will just slow
> +	down the revision walker.

As I remarked on IRC earlier, this will also show up in the man page of 
git-diff, too.  Rather funny, no?

Ciao,
Dscho