From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Junio C Hamano" <junkio@cox.net>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH 1/5] pretty describe: add name info to struct commit
Date: Sun, 4 Nov 2007 14:22:28 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711041420430.4362@racer.site> (raw)
In-Reply-To: <20071104140700.GB3078@steel.home>
Hi,
On Sun, 4 Nov 2007, Alex Riesen wrote:
> Ren? Scharfe, Sun, Nov 04, 2007 12:48:22 +0100:
> > diff --git a/commit.h b/commit.h
> > index b661503..80e94b9 100644
> > --- a/commit.h
> > +++ b/commit.h
> > @@ -18,6 +18,9 @@ struct commit {
> > struct commit_list *parents;
> > struct tree *tree;
> > char *buffer;
> > + char *name;
> > + unsigned int name_flags;
> > + char name_prio;
> > };
>
> It increases size of struct commit by ~12 bytes (assuming 4byte
> allignment), and this is a popular structure.
I was just about to say something similar.
But there is a wonderful solution: Have a look at decorate.[ch]. This is
the structure you should use IMHO.
Ciao,
Dscho
next prev parent reply other threads:[~2007-11-04 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 11:48 [PATCH 1/5] pretty describe: add name info to struct commit René Scharfe
2007-11-04 14:07 ` Alex Riesen
2007-11-04 14:22 ` Johannes Schindelin [this message]
2007-11-04 15:06 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711041420430.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).