From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Alex Riesen <raa.lkml@gmail.com>,
Michael Cohen <michaeljosephcohen@mac.com>,
Gerrit Pape <pape@smarden.org>,
"Fernando J. Pereda" <ferdy@gentoo.org>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty
Date: Tue, 6 Nov 2007 15:51:09 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711061550580.4362@racer.site> (raw)
In-Reply-To: <20071106154740.GA24505@sigill.intra.peff.net>
Hi,
On Tue, 6 Nov 2007, Jeff King wrote:
> On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote:
>
> > > > So? Why *STOP* reading the mails if just one of the directories could
> > > > not be opened? IOW, I suggest:
> > >
> > > Because you are then trying to apply a patch series with some patches
> > > potentially missing? Continuing only on errno == ENOENT seems prudent.
> >
> > I fail to see how the absence of one of cur/ or new/ can lead to the
> > absence of patches. You could forget to save some patches, yes, but the
> > presence of cur/ and new/ is no indicator for that.
>
> Read my message again. Alex is proposing ignoring errors in opening the
> directories; I am proposing ignoring such errors _only_ when the error
> is that the directory does not exist.
>
> IOW, if there is some other error in opening the directory, it should be
> fatal, because you might be missing patches.
Yeah, sorry, I missed that.
Ciao,
Dscho
next prev parent reply other threads:[~2007-11-06 15:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 14:15 [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty Gerrit Pape
2007-10-26 16:01 ` Fernando J. Pereda
2007-11-05 12:49 ` Gerrit Pape
2007-11-05 12:58 ` Jakub Narebski
2007-11-05 21:26 ` Jeff King
2007-11-05 22:52 ` Alex Riesen
2007-11-06 1:41 ` Michael Cohen
2007-11-06 7:28 ` Alex Riesen
2007-11-06 7:51 ` Jeff King
2007-11-06 11:01 ` Johannes Schindelin
2007-11-06 15:47 ` Jeff King
2007-11-06 15:51 ` Johannes Schindelin [this message]
2007-11-06 16:35 ` Karl Hasselström
2007-11-06 16:58 ` Johannes Schindelin
2007-11-06 21:50 ` Alex Riesen
2007-11-06 8:54 ` [PATCH amend] git-mailsplit: with maildirs not only process cur/, but also new/ Gerrit Pape
2007-11-08 2:09 ` Junio C Hamano
2007-11-08 2:31 ` Jeff King
2007-11-08 7:24 ` Alex Riesen
2007-11-08 7:31 ` Fernando J. Pereda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711061550580.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=ferdy@gentoo.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michaeljosephcohen@mac.com \
--cc=pape@smarden.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).