From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty Date: Tue, 6 Nov 2007 15:51:09 +0000 (GMT) Message-ID: References: <20071026141539.29928.qmail@d3691352d65cf2.315fe32.mid.smarden.org> <20071026160118.GA5076@ferdyx.org> <20071105124920.17726.qmail@746e9cce42b49f.315fe32.mid.smarden.org> <20071105225258.GC4208@steel.home> <635FFEC2-2489-443B-8425-DF2B58BE23C2@mac.com> <20071106072831.GA3021@steel.home> <20071106075150.GA21694@sigill.intra.peff.net> <20071106154740.GA24505@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Alex Riesen , Michael Cohen , Gerrit Pape , "Fernando J. Pereda" , git@vger.kernel.org, Junio C Hamano To: Jeff King X-From: git-owner@vger.kernel.org Tue Nov 06 16:52:31 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpQj1-0007qc-2d for gcvg-git-2@gmane.org; Tue, 06 Nov 2007 16:52:23 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbXKFPwH (ORCPT ); Tue, 6 Nov 2007 10:52:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752208AbXKFPwG (ORCPT ); Tue, 6 Nov 2007 10:52:06 -0500 Received: from mail.gmx.net ([213.165.64.20]:42399 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752871AbXKFPwF (ORCPT ); Tue, 6 Nov 2007 10:52:05 -0500 Received: (qmail invoked by alias); 06 Nov 2007 15:52:03 -0000 Received: from unknown (EHLO [138.251.11.74]) [138.251.11.74] by mail.gmx.net (mp037) with SMTP; 06 Nov 2007 16:52:03 +0100 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1/zgGweHgDzTAN7rQbCXUoIUVZet7EZXNhnbo45wx b5g91E2OPXb5Co X-X-Sender: gene099@racer.site In-Reply-To: <20071106154740.GA24505@sigill.intra.peff.net> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Tue, 6 Nov 2007, Jeff King wrote: > On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote: > > > > > So? Why *STOP* reading the mails if just one of the directories could > > > > not be opened? IOW, I suggest: > > > > > > Because you are then trying to apply a patch series with some patches > > > potentially missing? Continuing only on errno == ENOENT seems prudent. > > > > I fail to see how the absence of one of cur/ or new/ can lead to the > > absence of patches. You could forget to save some patches, yes, but the > > presence of cur/ and new/ is no indicator for that. > > Read my message again. Alex is proposing ignoring errors in opening the > directories; I am proposing ignoring such errors _only_ when the error > is that the directory does not exist. > > IOW, if there is some other error in opening the directory, it should be > fatal, because you might be missing patches. Yeah, sorry, I missed that. Ciao, Dscho