From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty Date: Tue, 6 Nov 2007 16:58:48 +0000 (GMT) Message-ID: References: <20071026141539.29928.qmail@d3691352d65cf2.315fe32.mid.smarden.org> <20071026160118.GA5076@ferdyx.org> <20071105124920.17726.qmail@746e9cce42b49f.315fe32.mid.smarden.org> <20071105225258.GC4208@steel.home> <635FFEC2-2489-443B-8425-DF2B58BE23C2@mac.com> <20071106072831.GA3021@steel.home> <20071106075150.GA21694@sigill.intra.peff.net> <20071106154740.GA24505@sigill.intra.peff.net> <20071106163548.GA8207@diana.vm.bytemark.co.uk> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Jeff King , Alex Riesen , Michael Cohen , Gerrit Pape , "Fernando J. Pereda" , git@vger.kernel.org, Junio C Hamano To: Karl =?iso-8859-1?Q?Hasselstr=F6m?= X-From: git-owner@vger.kernel.org Tue Nov 06 18:00:42 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpRmu-0008Q9-O2 for gcvg-git-2@gmane.org; Tue, 06 Nov 2007 18:00:29 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831AbXKFQ7p (ORCPT ); Tue, 6 Nov 2007 11:59:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753578AbXKFQ7p (ORCPT ); Tue, 6 Nov 2007 11:59:45 -0500 Received: from mail.gmx.net ([213.165.64.20]:36830 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753562AbXKFQ7o (ORCPT ); Tue, 6 Nov 2007 11:59:44 -0500 Received: (qmail invoked by alias); 06 Nov 2007 16:59:42 -0000 Received: from unknown (EHLO [138.251.11.74]) [138.251.11.74] by mail.gmx.net (mp019) with SMTP; 06 Nov 2007 17:59:42 +0100 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1+SGj1S9QmSljxgWVxhyNy+0h8az2e2vH9/lD80lS aiALI9k57wmAZL X-X-Sender: gene099@racer.site In-Reply-To: <20071106163548.GA8207@diana.vm.bytemark.co.uk> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Tue, 6 Nov 2007, Karl Hasselstr?m wrote: > On 2007-11-06 15:51:09 +0000, Johannes Schindelin wrote: > > > On Tue, 6 Nov 2007, Jeff King wrote: > > > > > On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote: > > > > > > > I fail to see how the absence of one of cur/ or new/ can lead to > > > > the absence of patches. You could forget to save some patches, > > > > yes, but the presence of cur/ and new/ is no indicator for that. > > > > > > Read my message again. Alex is proposing ignoring errors in > > > opening the directories; I am proposing ignoring such errors > > > _only_ when the error is that the directory does not exist. > > > > > > IOW, if there is some other error in opening the directory, it > > > should be fatal, because you might be missing patches. > > > > Yeah, sorry, I missed that. > > I think it might actually not be totally unreasonable to error out > unless both directories exist. From > http://www.qmail.org/qmail-manual-html/man5/maildir.html: > > A directory in maildir format has three subdirectories, all on the > same filesystem: tmp, new, and cur. > > In other words, if it doesn't have these three directories, it isn't a > Maildir directory. > > On the other hand, one could argue that requiring both dirs to exist > is being too picky. Not only that. The recent patch for OSX' mail program would be trivial if we did not error out: the array would just contain cur, new and Messages. Ciao, Dscho