From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Symonds <dsymonds@gmail.com>
Cc: Brian Gernhardt <benji@silverinsanity.com>,
Jon Smirl <jonsmirl@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
gitster@pobox.com
Subject: [PATCH 2/2] git status: show relative paths when run in a subdirectory
Date: Thu, 8 Nov 2007 00:12:22 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711080011170.4362@racer.site> (raw)
In-Reply-To: <ee77f5c20711071531q5acc4d06u264f5daad7c04cc4@mail.gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
This looks a bit ugly because quote_crlf() is now also called
on the untracked files, which are not NUL terminated.
Maybe someone has an idea how to do this more elegantly.
builtin-runstatus.c | 1 +
wt-status.c | 50 ++++++++++++++++++++++++++++++++++++++++++--------
wt-status.h | 1 +
3 files changed, 44 insertions(+), 8 deletions(-)
diff --git a/builtin-runstatus.c b/builtin-runstatus.c
index 2db25c8..8d167a9 100644
--- a/builtin-runstatus.c
+++ b/builtin-runstatus.c
@@ -14,6 +14,7 @@ int cmd_runstatus(int argc, const char **argv, const char *prefix)
git_config(git_status_config);
wt_status_prepare(&s);
+ s.prefix = prefix;
for (i = 1; i < argc; i++) {
if (!strcmp(argv[i], "--color"))
diff --git a/wt-status.c b/wt-status.c
index 03b5ec4..7386d41 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -82,16 +82,48 @@ static void wt_status_print_trailer(struct wt_status *s)
color_fprintf_ln(s->fp, color(WT_STATUS_HEADER), "#");
}
-static const char *quote_crlf(const char *in, char *buf, size_t sz)
+static const char *quote_crlf(const char *in, int len, char *buf, size_t sz,
+ const char *prefix)
{
const char *scan;
char *out;
const char *ret = in;
+ int off = 0;
+
+ if (len < 0)
+ len = strlen(in);
+
+ if (prefix) {
+ while (prefix[off] && off < len && prefix[off] == in[off])
+ if (prefix[off] == '/') {
+ prefix += off + 1;
+ in += off + 1;
+ len -= off + 1;
+ off = 0;
+ } else
+ off++;
+ for (off = 0; *prefix; prefix++)
+ if (*prefix == '/') {
+ if (off + 4 >= sz) {
+ warning ("Could not prefix path: %s",
+ in);
+ return in;
+ }
+ strcpy(buf + off, "../");
+ off += 3;
+ }
+ ret = buf;
+ }
- for (scan = in, out = buf; *scan; scan++) {
+ for (scan = in, out = buf + off; len; scan++, len--) {
int ch = *scan;
int quoted;
+ if (out - buf + 3 >= sz) {
+ warning ("Could not quote path: %s", in);
+ break;
+ }
+
switch (ch) {
case '\n':
quoted = 'n';
@@ -118,8 +150,8 @@ static void wt_status_print_filepair(struct wt_status *s,
const char *one, *two;
char onebuf[PATH_MAX], twobuf[PATH_MAX];
- one = quote_crlf(p->one->path, onebuf, sizeof(onebuf));
- two = quote_crlf(p->two->path, twobuf, sizeof(twobuf));
+ one = quote_crlf(p->one->path, -1, onebuf, sizeof(onebuf), s->prefix);
+ two = quote_crlf(p->two->path, -1, twobuf, sizeof(twobuf), s->prefix);
color_fprintf(s->fp, color(WT_STATUS_HEADER), "#\t");
switch (p->status) {
@@ -215,8 +247,8 @@ static void wt_status_print_initial(struct wt_status *s)
for (i = 0; i < active_nr; i++) {
color_fprintf(s->fp, color(WT_STATUS_HEADER), "#\t");
color_fprintf_ln(s->fp, color(WT_STATUS_UPDATED), "new file: %s",
- quote_crlf(active_cache[i]->name,
- buf, sizeof(buf)));
+ quote_crlf(active_cache[i]->name, -1,
+ buf, sizeof(buf), s->prefix));
}
if (active_nr)
wt_status_print_trailer(s);
@@ -254,6 +286,7 @@ static void wt_status_print_untracked(struct wt_status *s)
const char *x;
int i;
int shown_header = 0;
+ char buf[PATH_MAX];
memset(&dir, 0, sizeof(dir));
@@ -291,8 +324,9 @@ static void wt_status_print_untracked(struct wt_status *s)
shown_header = 1;
}
color_fprintf(s->fp, color(WT_STATUS_HEADER), "#\t");
- color_fprintf_ln(s->fp, color(WT_STATUS_UNTRACKED), "%.*s",
- ent->len, ent->name);
+ color_fprintf_ln(s->fp, color(WT_STATUS_UNTRACKED), "%s",
+ quote_crlf(ent->name, ent->len,
+ buf, sizeof(buf), s->prefix));
}
}
diff --git a/wt-status.h b/wt-status.h
index 7744932..f58ebcb 100644
--- a/wt-status.h
+++ b/wt-status.h
@@ -23,6 +23,7 @@ struct wt_status {
int workdir_untracked;
const char *index_file;
FILE *fp;
+ const char *prefix;
};
int git_status_config(const char *var, const char *value);
--
1.5.3.5.1597.g7191
next prev parent reply other threads:[~2007-11-08 0:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 22:15 Inconsistencies with git log Jon Smirl
2007-11-07 22:42 ` Johannes Schindelin
2007-11-07 22:45 ` Jon Smirl
2007-11-07 22:58 ` Johannes Schindelin
2007-11-07 23:03 ` Jon Smirl
2007-11-07 23:11 ` Johannes Schindelin
2007-11-07 23:16 ` Jon Smirl
2007-11-07 23:29 ` Jon Smirl
2007-11-08 0:04 ` Johannes Schindelin
2007-11-08 0:09 ` Jon Smirl
2007-11-08 0:16 ` Andreas Ericsson
2007-11-08 0:35 ` Johannes Schindelin
2007-11-09 15:54 ` Linus Torvalds
2007-11-09 17:20 ` Jon Smirl
2007-11-09 17:38 ` Linus Torvalds
2007-11-09 17:53 ` Linus Torvalds
2007-11-09 18:04 ` Jon Smirl
2007-11-09 18:14 ` Linus Torvalds
2007-11-09 18:22 ` Peter Baumann
2007-11-09 18:35 ` Junio C Hamano
2007-11-09 18:37 ` Jakub Narebski
2007-11-09 18:39 ` Peter Baumann
2007-11-09 18:36 ` Linus Torvalds
2007-11-09 17:41 ` Jakub Narebski
2007-11-08 9:24 ` Wincent Colaiuta
2007-11-08 18:28 ` Daniel Barkalow
2007-11-07 23:19 ` Brian Gernhardt
2007-11-07 23:31 ` David Symonds
2007-11-08 0:09 ` Johannes Schindelin
2007-11-08 0:14 ` David Symonds
2007-11-08 0:52 ` Brian Gernhardt
2007-11-08 0:10 ` [PATCH 1/2] Makefile: wt-status.h is also a lib header Johannes Schindelin
2007-11-08 0:11 ` Inconsistencies with git log Andreas Ericsson
2007-11-08 8:29 ` Peter Baumann
2007-11-08 13:16 ` David Symonds
2007-11-08 13:40 ` Andreas Ericsson
2007-11-08 21:21 ` Alex Riesen
2007-11-08 21:23 ` Alex Riesen
2007-11-08 0:12 ` Johannes Schindelin [this message]
2007-11-08 0:53 ` [PATCH 2/2] git status: show relative paths when run in a subdirectory David Symonds
2007-11-08 1:00 ` Johannes Schindelin
2007-11-08 8:26 ` Junio C Hamano
2007-11-09 15:30 ` [PATCH REPLACEMENT for " Johannes Schindelin
2007-11-10 12:08 ` Michel Marti
2007-11-10 14:10 ` Johannes Schindelin
2007-11-08 9:19 ` Inconsistencies with git log Wincent Colaiuta
2007-11-10 22:51 ` Miles Bader
2007-11-07 23:00 ` David Symonds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711080011170.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=benji@silverinsanity.com \
--cc=dsymonds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).