git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Benoit Sigoure <tsuna@lrde.epita.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jonas Fonseca <fonseca@diku.dk>,
	git@vger.kernel.org
Subject: Re: [BUG] git-rebase fails when a commit message contains a diff
Date: Fri, 9 Nov 2007 13:20:40 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0711091319420.4362@racer.site> (raw)
In-Reply-To: <6FCE17E3-9FAA-4676-B12A-369B31743DA6@lrde.epita.fr>

Hi,

On Fri, 9 Nov 2007, Benoit Sigoure wrote:

> On Nov 9, 2007, at 3:28 AM, Johannes Schindelin wrote:
> 
> > Would that not be easier to read as
> > 
> > 		test t = "$INTERACTIVE" &&
> > 			git_editor "$TODO" || die "Could not execute editor"
> 
> Hmm this will `die' if you're not running interactively.

D'oh.  Of course I meant

		test -z "$INTERACTIVE" || git_editor "$TODO" || die ...

Ciao,
Dscho

  parent reply	other threads:[~2007-11-09 13:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09  1:12 [BUG] git-rebase fails when a commit message contains a diff Jonas Fonseca
2007-11-09  1:39 ` Junio C Hamano
2007-11-09  1:51   ` Junio C Hamano
2007-11-09  2:18     ` Junio C Hamano
2007-11-09  2:28       ` Johannes Schindelin
2007-11-09  2:37         ` Junio C Hamano
2007-11-09 14:19           ` Johannes Schindelin
2007-11-11 22:31           ` Björn Steinbrink
2007-11-09  7:57         ` Benoit Sigoure
2007-11-09  8:57           ` Johannes Sixt
2007-11-09  9:05             ` Ralf Wildenhues
2007-11-09  9:07             ` Benoit Sigoure
2007-11-09 13:20           ` Johannes Schindelin [this message]
2007-11-09 10:29         ` Andreas Ericsson
2007-11-09  7:03     ` Steffen Prohaska
2007-11-09 14:18       ` Johannes Schindelin
2007-11-09 14:29         ` Steffen Prohaska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0711091319420.4362@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=fonseca@diku.dk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tsuna@lrde.epita.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).