From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: git@vger.kernel.org, krh@redhat.com, gitster@pobox.com
Subject: [PATCH 4/6] builtin-commit --s: add a newline if the last line was no S-O-B
Date: Sun, 11 Nov 2007 17:36:27 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711111736170.4362@racer.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0711111730580.4362@racer.site>
The rule is this: if the last line already contains the sign off by the
current committer, do nothing. If it contains another sign off, just
add the sign off of the current committer. If the last line does not
contain a sign off, add a new line before adding the sign off.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
builtin-commit.c | 5 ++++-
t/t7500-commit.sh | 1 +
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 6b1507d..66d7e5e 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -196,8 +196,11 @@ static int prepare_log_message(const char *index_file, const char *prefix)
for (i = sb.len - 1; i > 0 && sb.buf[i - 1] != '\n'; i--)
; /* do nothing */
- if (prefixcmp(sb.buf + i, sob.buf))
+ if (prefixcmp(sb.buf + i, sob.buf)) {
+ if (prefixcmp(sb.buf + i, sign_off_header))
+ strbuf_addch(&sb, '\n');
strbuf_addbuf(&sb, &sob);
+ }
strbuf_release(&sob);
}
diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
index 13d5a0c..e0be2ed 100755
--- a/t/t7500-commit.sh
+++ b/t/t7500-commit.sh
@@ -95,6 +95,7 @@ test_expect_success 'commit message from file should override template' '
cat > expect << EOF
zort
+
Signed-off-by: C O Mitter <committer@example.com>
EOF
--
1.5.3.5.1693.g26ed
next prev parent reply other threads:[~2007-11-11 17:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 17:35 [PATCH 0/6] Various (replacement) patches to builtin-commit Johannes Schindelin
2007-11-11 17:35 ` [PATCH 1/6] builtin-commit: fix author date with --amend --author=<author> Johannes Schindelin
2007-11-12 19:38 ` Kristian Høgsberg
2007-11-12 20:12 ` Johannes Schindelin
2007-11-13 0:37 ` Junio C Hamano
2007-11-11 17:35 ` [PATCH 2/6] git status: show relative paths when run in a subdirectory Johannes Schindelin
2007-11-11 17:35 ` [PATCH 3/6] builtin-commit: fix --signoff Johannes Schindelin
2007-11-11 17:36 ` Johannes Schindelin [this message]
2007-11-11 17:36 ` [PATCH 5/6] builtin-commit: resurrect behavior for multiple -m options Johannes Schindelin
2007-11-11 19:42 ` Pierre Habouzit
2007-11-11 20:42 ` Johannes Schindelin
2007-11-11 22:11 ` Pierre Habouzit
2007-11-11 22:13 ` Pierre Habouzit
2007-11-11 17:36 ` [PATCH 6/6] builtin-commit: Add newline when showing which commit was created Johannes Schindelin
2007-12-01 22:21 ` Jeff King
2007-12-01 22:41 ` Johannes Schindelin
2007-12-02 5:40 ` Jeff King
2007-12-02 12:13 ` Johannes Schindelin
2007-12-02 16:54 ` Jeff King
2007-12-02 17:18 ` Johannes Schindelin
2007-12-02 18:34 ` Junio C Hamano
2007-12-02 21:20 ` Johannes Schindelin
2007-12-03 7:33 ` Junio C Hamano
2007-12-03 7:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711111736170.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).