From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: benji@silverinsanity.com, aroben@apple.com, dak@gnu.org,
git@vger.kernel.org
Subject: Re: [PATCH] t7005-editor.sh: Don't invoke real vi when it is in GIT_EXEC_PATH
Date: Sun, 11 Nov 2007 17:44:14 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711111742010.4362@racer.site> (raw)
In-Reply-To: <1194802691-27610-1-git-send-email-B.Steinbrink@gmx.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 675 bytes --]
Hi,
On Sun, 11 Nov 2007, Björn Steinbrink wrote:
> The git wrapper executable always prepends the GIT_EXEC_PATH build
> variable to the current PATH, so prepending "." to the PATH is not
> enough to give precedence to the fake vi executable.
>
> The --exec-path option allows to prepend a directory to PATH even before
> GIT_EXEC_PATH (which is added anyway), so we can use that instead.
Hmm. This will probably stop working when you do not have git installed,
because you now tell git to search for git programs in ".", where they are
not. Probably git-commit executes your installed write-tree, commit-tree
and friends, instead of the compiled ones.
Ciao,
Dscho
next prev parent reply other threads:[~2007-11-11 17:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 22:03 t7005 and vi in GIT_EXEC_PATH Brian Gernhardt
2007-11-10 22:09 ` David Kastrup
2007-11-10 22:45 ` Brian Gernhardt
2007-11-11 15:58 ` Johannes Schindelin
2007-11-11 16:10 ` Brian Gernhardt
2007-11-11 16:28 ` Johannes Schindelin
2007-11-11 19:43 ` Junio C Hamano
2007-11-11 20:33 ` [PATCH] Use the best available exec path only Björn Steinbrink
2007-11-11 20:50 ` Johannes Schindelin
2007-11-11 21:12 ` Jakub Narebski
2007-11-11 21:17 ` Björn Steinbrink
2007-11-11 21:40 ` Johannes Schindelin
2007-11-11 21:29 ` t7005 and vi in GIT_EXEC_PATH Junio C Hamano
2007-11-11 17:38 ` [PATCH] t7005-editor.sh: Don't invoke real vi when it is " Björn Steinbrink
2007-11-11 17:44 ` Johannes Schindelin [this message]
2007-11-11 17:49 ` Brian Gernhardt
2007-11-11 18:31 ` Johannes Schindelin
2007-11-11 18:01 ` Björn Steinbrink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711111742010.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=B.Steinbrink@gmx.de \
--cc=aroben@apple.com \
--cc=benji@silverinsanity.com \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).