From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Lars Hjemli <hjemli@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Jakub Narebski <jnareb@gmail.com>, Jon Smirl <jonsmirl@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] for-each-ref: fix setup of option-parsing for --sort
Date: Sun, 11 Nov 2007 19:19:04 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711111918470.4362@racer.site> (raw)
In-Reply-To: <1194713274-31200-1-git-send-email-hjemli@gmail.com>
Hi,
On Sat, 10 Nov 2007, Lars Hjemli wrote:
> The option value for --sort is already a pointer to a pointer to struct
> ref_sort, so just use it.
>
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>
> On Nov 10, 2007 5:25 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > Could you add a test for that too, please?
>
> Is this ok?
That's exactly what I had in mind.
Thank you,
Dscho
next prev parent reply other threads:[~2007-11-11 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 16:47 [PATCH] for-each-ref: fix setup of option-parsing for --sort Lars Hjemli
2007-11-10 18:58 ` Junio C Hamano
2007-11-11 19:19 ` Johannes Schindelin [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-10 14:10 gitweb, updating 'last changed' column on the project page Jon Smirl
2007-11-10 16:07 ` [PATCH] for-each-ref: fix setup of option-parsing for --sort Lars Hjemli
2007-11-10 16:25 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711111918470.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=jnareb@gmail.com \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).