From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: Obscure commit message formatting issue
Date: Sun, 11 Nov 2007 22:43:10 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711112240350.4362@racer.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0711111706490.29952@iabervon.org>
Hi,
On Sun, 11 Nov 2007, Daniel Barkalow wrote:
> On Sun, 11 Nov 2007, Junio C Hamano wrote:
>
> > Daniel Barkalow <barkalow@iabervon.org> writes:
> >
> > > The current code drops extra blank lines between the first line of a
> > > commit message (the summary line) and the remainder.
> >
> > The patch application side does even more. It not just strips
> > off the leading or trailing blank lines, but duplicate blank
> > lines in the middle and trailing whitespaces at the end of each
> > line.
> >
> > I am of two minds about the formatting side.
> >
> > The behaviour you found does not go far enough to correct all of
> > the above whitespace breakage the application side will fix up
> > on the generation side -- it only corrects one of them. We
> > might want to do more, instead of less that you seem to be
> > implying to favor.
>
> What I'm actually doing is working on a cover letter implementation.
Funny.
I am in the middle of cleaning out my personal git branch that has a messy
history, since I never rebased, but always merged. Now I decided to go
with rebasing.
And there I found an implementation of a cover letter. You might want to
be interested ;-)
http://repo.or.cz/w/git/dscho.git?a=shortlog;h=cover-letter
Ciao,
Dscho
next prev parent reply other threads:[~2007-11-11 22:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 21:28 Obscure commit message formatting issue Daniel Barkalow
2007-11-11 22:01 ` Junio C Hamano
2007-11-11 22:30 ` Daniel Barkalow
2007-11-11 22:43 ` Johannes Schindelin [this message]
2007-11-11 22:50 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711112240350.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).