From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sam Vilain <sam@vilain.net>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Fix rev-list when showing objects involving submodules
Date: Mon, 12 Nov 2007 21:25:22 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711122124500.4362@racer.site> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711121231570.3062@woody.linux-foundation.org>
Hi,
On Mon, 12 Nov 2007, Linus Torvalds wrote:
> On Mon, 12 Nov 2007, Johannes Schindelin wrote:
> >
> > You mean something like
> >
> > else if (S_ISREG(entry.mod) || S_ISLNK(entry.mod))
> >
> > Hmm? Sure, I have no preference there.
>
> Maybe more along the line of something like this?
>
> In general, I suspect we should try to start moving away from using the
> "S_ISLNK()" like things for internal git state. It was a mistake to just
> assume the numbers all were same across all systems in the first place.
>
> So this just converts to the "object_type", and then uses a case
> statement.
Sure. Just add the test from my patch, and we're fixed.
Ciao,
Dscho
prev parent reply other threads:[~2007-11-12 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 23:35 [PATCH] Fix rev-list when showing objects involving submodules Johannes Schindelin
2007-11-12 19:54 ` Sam Vilain
2007-11-12 20:21 ` Johannes Schindelin
2007-11-12 20:43 ` Linus Torvalds
2007-11-12 21:25 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711122124500.4362@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sam@vilain.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).