From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH 10/11] Introduce git_etc_gitconfig() that encapsulates access of ETC_GITCONFIG. Date: Tue, 13 Nov 2007 21:43:19 +0000 (GMT) Message-ID: References: <1194984306-3181-1-git-send-email-johannes.sixt@telecom.at> <1194984306-3181-11-git-send-email-johannes.sixt@telecom.at> <200711132235.13463.johannes.sixt@telecom.at> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: git@vger.kernel.org, Junio C Hamano To: Johannes Sixt X-From: git-owner@vger.kernel.org Tue Nov 13 22:43:57 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Is3Y3-00053H-VW for gcvg-git-2@gmane.org; Tue, 13 Nov 2007 22:43:56 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762069AbXKMVnj (ORCPT ); Tue, 13 Nov 2007 16:43:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761993AbXKMVnj (ORCPT ); Tue, 13 Nov 2007 16:43:39 -0500 Received: from mail.gmx.net ([213.165.64.20]:35829 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761647AbXKMVni (ORCPT ); Tue, 13 Nov 2007 16:43:38 -0500 Received: (qmail invoked by alias); 13 Nov 2007 21:43:36 -0000 Received: from unknown (EHLO openvpn-client) [138.251.11.103] by mail.gmx.net (mp045) with SMTP; 13 Nov 2007 22:43:36 +0100 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1/82iJQB8r8olzaD+tOqiQnvJj1G6xffzIr6SFm0i EbGBfq2B4IQquY X-X-Sender: gene099@racer.site In-Reply-To: <200711132235.13463.johannes.sixt@telecom.at> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Tue, 13 Nov 2007, Johannes Sixt wrote: > On Tuesday 13 November 2007 22:22, Johannes Schindelin wrote: > > > On Tue, 13 Nov 2007, Johannes Sixt wrote: > > > diff --git a/config.c b/config.c > > > index dc3148d..dd7e9ad 100644 > > > --- a/config.c > > > +++ b/config.c > > > @@ -452,6 +452,11 @@ int git_config_from_file(config_fn_t fn, const char > > > *filename) return ret; > > > } > > > > > > +const char *git_etc_gitconfig(void) > > > +{ > > > + return ETC_GITCONFIG; > > > +} > > > + > > > > Wouldn't this logically belong into environment.c? > > I don't think so. environment.c is about things that concern the > repository. This is really only about configuration. I thought that environment.c is about getting certain settings from the environment. In that sense, git_etc_gitconfig() would live a happier life there. But I do not care all that deeply. I know _I_ would have looked for it in environment.c first, but then, there's always good ole' git-grep. Ciao, Dscho