From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] rebase -i: give rerere a chance
Date: Thu, 22 Nov 2007 11:18:10 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711221117590.27959@racer.site> (raw)
In-Reply-To: <7vlk8q7hzg.fsf@gitster.siamese.dyndns.org>
Like non-interactive rebase, interactive mode now calls rerere when
appropriate.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
While I was working with rebase -i yesterday, I realised that it
did not call rerere at all. And sure enough, there was a
NEEDSWORK in rebase -i for that.
Now, I _hope_ I got all the locations where the rerere should be
cleared, but this could use a few pairs of eyeballs.
git-rebase--interactive.sh | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index ead7da7..a6dc72a 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -81,6 +81,7 @@ make_patch () {
die_with_patch () {
make_patch "$1"
+ git rerere
die "$2"
}
@@ -166,13 +167,13 @@ pick_one_preserving_merges () {
msg="$(git cat-file commit $sha1 | sed -e '1,/^$/d')"
# No point in merging the first parent, that's HEAD
new_parents=${new_parents# $first_parent}
- # NEEDSWORK: give rerere a chance
if ! GIT_AUTHOR_NAME="$GIT_AUTHOR_NAME" \
GIT_AUTHOR_EMAIL="$GIT_AUTHOR_EMAIL" \
GIT_AUTHOR_DATE="$GIT_AUTHOR_DATE" \
output git merge $STRATEGY -m "$msg" \
$new_parents
then
+ git rerere
printf "%s\n" "$msg" > "$GIT_DIR"/MERGE_MSG
die Error redoing merge $sha1
fi
@@ -360,6 +361,7 @@ do
--abort)
comment_for_reflog abort
+ git rerere clear
test -d "$DOTEST" || die "No interactive rebase running"
HEADNAME=$(cat "$DOTEST"/head-name)
@@ -376,6 +378,7 @@ do
--skip)
comment_for_reflog skip
+ git rerere clear
test -d "$DOTEST" || die "No interactive rebase running"
output git reset --hard && do_rest
--
1.5.3.6.1977.g54d30
next prev parent reply other threads:[~2007-11-22 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 9:21 Reordering lines in "git-rebase -i" task sheet Junio C Hamano
2007-11-22 11:15 ` [PATCH] rebase -i: move help to end of todo file Johannes Schindelin
2007-11-22 11:41 ` [PATCH] Adjust t3404 to ignore empty lines in the " Johannes Schindelin
2007-11-22 11:46 ` [PATCH] rebase -i: move help to end of " Junio C Hamano
2007-11-22 12:30 ` Johannes Schindelin
2007-11-22 12:31 ` Jeff King
2007-11-22 11:18 ` Johannes Schindelin [this message]
2007-11-29 0:17 ` [PATCH] rebase -i: give rerere a chance Junio C Hamano
2007-11-29 0:22 ` Johannes Schindelin
2007-11-29 9:59 ` David Kastrup
2007-11-22 19:25 ` Reordering lines in "git-rebase -i" task sheet David Brown
2007-11-22 22:11 ` Johannes Schindelin
2007-11-23 8:54 ` Andy Parkins
2007-11-26 13:14 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711221117590.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).