git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Add 'git fast-export', the sister of 'git fast-import'
Date: Tue, 27 Nov 2007 11:31:44 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0711271127440.27959@racer.site> (raw)
In-Reply-To: <20071127020842.GN14735@spearce.org>

Hi,

On Mon, 26 Nov 2007, Shawn O. Pearce wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > This program dumps (parts of) a git repository in the format that
> > fast-import understands.
> ...
> > +-------------------------------------------------------------------
> > +$ git fast-export --all | (cd /empty/repository && git fast-import)
> > +-------------------------------------------------------------------
> > +
> > +This will export the whole repository and import it into the existing
> > +empty repository.  Except for reencoding commits that are not in
> > +UTF-8, it would be a one-to-one mirror.
> 
> WTF?
> 
> Why are you reencoding the commits on output in fast-export? Why aren't 
> you dumping them raw to the stream?  fast-import takes them raw.  Oh, it 
> doesn't have a way to set the encoding header. DOH.

Not only that... FTFD:

~ Commit messages are free-form and are not interpreted by Git.  
~ Currently they must be encoded in UTF-8, as fast-import does not permit 
~ other encodings to be specified.

So the documentation stated very much that I _had_ to do it that way.

> I think this should be prefixed by fast-import patch to teach it 
> something like "encoding N" as a subcommand of commit, so that you can 
> feed data in a non UTF-8 encoding and get it to include the proper 
> encoding header in the commit object it creates.  That way a pipeline 
> like the above really does create a duplicate repository, with the same 
> commit SHA-1s, even if the commits weren't in UTF-8.

IMHO it's not worth that hassle.  People who want to use fast-import 
usually want something fast which works, and not bother with specifying 
encodings.

Further, if you go down that road, some people will want to be able to say 
"that commit is KOI-8, this one is UTF-8, and the third is encoded in 
pre-Christian Tibetan runes."

But maybe I am wrong.

Ciao,
Dscho

  reply	other threads:[~2007-11-27 11:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-25 21:37 [PATCH] Add 'git fast-export', the sister of 'git fast-import' Johannes Schindelin
2007-11-26  1:16 ` Junio C Hamano
2007-11-26 12:39   ` Johannes Schindelin
2007-11-26 17:55     ` Junio C Hamano
2007-11-27 12:14       ` Johannes Schindelin
2007-11-27  2:08 ` Shawn O. Pearce
2007-11-27 11:31   ` Johannes Schindelin [this message]
2007-11-27 23:40     ` Jakub Narebski
2007-11-28 12:22       ` Johannes Schindelin
2007-11-28 12:56         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0711271127440.27959@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).