From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] setup_git_directory: Setup cwd properly if worktree is found
Date: Tue, 27 Nov 2007 14:46:39 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711271446080.27959@racer.site> (raw)
In-Reply-To: <fcaeb9bf0711270612p52ce20eaue39eac1d529c3fd3@mail.gmail.com>
Hi,
On Tue, 27 Nov 2007, Nguyen Thai Ngoc Duy wrote:
> Question time. setup_git_directory_gently() can be happy even if there
> is no repository. Now if we move version check into setup_..._gently and
> it finds git program is too old to handle the repository, what would we
> do? die() like in check_repository_format() or tell the caller there is
> no repository?
In the interest of least surprise, die().
Ciao,
Dscho
next prev parent reply other threads:[~2007-11-27 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 11:24 [PATCH] setup_git_directory: Setup cwd properly if worktree is found Nguyễn Thái Ngọc Duy
2007-11-12 11:57 ` Johannes Schindelin
[not found] ` <fcaeb9bf0711120413w180c07e1qbf1b186753593d7@mail.gmail.com>
2007-11-12 12:31 ` Johannes Schindelin
2007-11-27 14:12 ` Nguyen Thai Ngoc Duy
2007-11-27 14:46 ` Johannes Schindelin [this message]
2007-11-12 12:53 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711271446080.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).