git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] Add 'git fast-export', the sister of 'git fast-import'
Date: Wed, 28 Nov 2007 12:22:52 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0711281221090.27959@racer.site> (raw)
In-Reply-To: <fii9ta$b2j$1@ger.gmane.org>

Hi,

On Wed, 28 Nov 2007, Jakub Narebski wrote:

> Johannes Schindelin wrote:
> 
> > On Mon, 26 Nov 2007, Shawn O. Pearce wrote:
> 
> >> I think this should be prefixed by fast-import patch to teach it 
> >> something like "encoding N" as a subcommand of commit, so that you 
> >> can feed data in a non UTF-8 encoding and get it to include the 
> >> proper encoding header in the commit object it creates.  That way a 
> >> pipeline like the above really does create a duplicate repository, 
> >> with the same commit SHA-1s, even if the commits weren't in UTF-8.
> > 
> > IMHO it's not worth that hassle.  People who want to use fast-import 
> > usually want something fast which works, and not bother with 
> > specifying encodings.
> 
> Well, when I am converting some repository which uses legacy encoding 
> (not utf-8), I'd like to use this git feature of specifying encoding; 
> actually, to be generic, it could be any header which would be added to 
> all created commit objects.
> 
> Yes, I could reencode commit messages...

Right.

> P.S. One nice use of proposed (at one time) 'note' header would be to 
> save revision identifier from the version control system you import (CVS 
> revision number, Subversion sequential revision number, etc.).

Why not put it into the commit message?  It is not information that git 
uses, so it does not belong into the commit header IMO.  (IIRC I made the 
same point already at the time 'note' was discussed.)

Ciao,
Dscho

  reply	other threads:[~2007-11-28 12:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-25 21:37 [PATCH] Add 'git fast-export', the sister of 'git fast-import' Johannes Schindelin
2007-11-26  1:16 ` Junio C Hamano
2007-11-26 12:39   ` Johannes Schindelin
2007-11-26 17:55     ` Junio C Hamano
2007-11-27 12:14       ` Johannes Schindelin
2007-11-27  2:08 ` Shawn O. Pearce
2007-11-27 11:31   ` Johannes Schindelin
2007-11-27 23:40     ` Jakub Narebski
2007-11-28 12:22       ` Johannes Schindelin [this message]
2007-11-28 12:56         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0711281221090.27959@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).