git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eyvind Bernhardsen <eyvind-git-list@orakel.ntnu.no>,
	Nicolas Pitre <nico@cam.org>,
	Nguyen Thai Ngoc Duy <pclouds@gmail.com>, Jan Hudec <bulb@ucw.cz>,
	git@vger.kernel.org
Subject: [PATCH 2/3] Include the objects needed for the builtin functions into libgit.a
Date: Sun, 2 Dec 2007 02:54:47 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0712020254370.27959@racer.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0712020146240.27959@racer.site>


For the upcoming change in execv_git_cmd() to call builtin functions
directly, it is necessary to be able to access the builtins, so
move the corresponding objects into libgit.a.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 Makefile |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index f000a5e..f9a62eb 100644
--- a/Makefile
+++ b/Makefile
@@ -314,7 +314,8 @@ LIB_OBJS = \
 	alloc.o merge-file.o path-list.o help.o unpack-trees.o $(DIFF_OBJS) \
 	color.o wt-status.o archive-zip.o archive-tar.o shallow.o utf8.o \
 	convert.o attr.o decorate.o progress.o mailmap.o symlinks.o remote.o \
-	transport.o bundle.o walker.o parse-options.o
+	transport.o bundle.o walker.o parse-options.o \
+	$(BUILTIN_OBJS)
 
 BUILTIN_OBJS = \
 	builtin-add.o \
@@ -785,12 +786,12 @@ strip: $(PROGRAMS) git$X
 	$(STRIP) $(STRIP_OPTS) $(PROGRAMS) git$X
 
 git.o: git.c common-cmds.h GIT-CFLAGS
-	$(QUIET_CC)$(CC) -DGIT_VERSION='"$(GIT_VERSION)"' \
+	$(QUIET_CC)$(CC) \
 		$(ALL_CFLAGS) -c $(filter %.c,$^)
 
 git$X: git.o $(BUILTIN_OBJS) $(GITLIBS)
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ git.o \
-		$(BUILTIN_OBJS) $(ALL_LDFLAGS) $(LIBS)
+		$(ALL_LDFLAGS) $(LIBS)
 
 help.o: common-cmds.h
 
@@ -894,7 +895,10 @@ git.o git.spec \
 	$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<
 
 exec_cmd.o: exec_cmd.c GIT-CFLAGS
-	$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) '-DGIT_EXEC_PATH="$(gitexecdir_SQ)"' $<
+	$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) \
+		-DGIT_EXEC_PATH='"$(gitexecdir_SQ)"' \
+		-DGIT_VERSION='"$(GIT_VERSION)"' \
+		$<
 builtin-init-db.o: builtin-init-db.c GIT-CFLAGS
 	$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) -DDEFAULT_GIT_TEMPLATE_DIR='"$(template_dir_SQ)"' $<
 
@@ -920,7 +924,7 @@ git-http-push$X: revision.o http.o http-push.o $(GITLIBS)
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
 		$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)
 
-$(LIB_OBJS) $(BUILTIN_OBJS): $(LIB_H)
+$(LIB_OBJS): $(LIB_H)
 $(patsubst git-%$X,%.o,$(PROGRAMS)): $(LIB_H) $(wildcard */*.h)
 builtin-revert.o builtin-runstatus.o wt-status.o: wt-status.h
 
-- 
1.5.3.6.2112.ge2263

  parent reply	other threads:[~2007-12-02  2:55 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27 15:02 [PATCH RFC] Move all dashed form git commands to libexecdir Nguyễn Thái Ngọc Duy
2007-11-27 15:12 ` Johannes Schindelin
2007-11-27 15:25 ` Nicolas Pitre
2007-11-27 16:04 ` [PATCH] " Nguyễn Thái Ngoc Duy
2007-11-27 16:18   ` Johannes Schindelin
2007-11-28  0:07     ` Jan Hudec
2007-11-28  1:13       ` Junio C Hamano
2007-11-28  8:18         ` Jan Hudec
2007-11-28  8:36         ` Nguyen Thai Ngoc Duy
2007-11-28 23:14           ` Junio C Hamano
2007-11-28 23:40             ` Johannes Schindelin
2007-11-28 23:48               ` Junio C Hamano
2007-11-29  0:01                 ` Johannes Schindelin
2007-11-29  0:59             ` A Large Angry SCM
2007-11-29  1:02               ` Junio C Hamano
2007-11-29  3:17             ` Nguyen Thai Ngoc Duy
2007-11-29 14:09               ` Nicolas Pitre
2007-11-29 22:36                 ` Junio C Hamano
2007-11-30  7:32                   ` Wincent Colaiuta
2007-11-30 11:28                   ` Eyvind Bernhardsen
2007-11-30 12:08                     ` [PATCH] transport.c: call dash-less form of receive-pack and upload-pack on remote Johannes Schindelin
2007-12-01  2:36                       ` Junio C Hamano
2007-12-01 10:17                         ` Johannes Schindelin
2007-12-01 19:30                           ` Junio C Hamano
2007-12-01 23:03                             ` Johannes Schindelin
2007-12-01 23:15                               ` Johannes Schindelin
2007-12-02  1:57                                 ` Junio C Hamano
2007-12-02  2:52                                 ` [PATCH 0/3] Call builtin functions directly, was " Johannes Schindelin
2007-12-02  2:54                                   ` [PATCH 1/3] Introduce release_all_objects() Johannes Schindelin
2007-12-02  2:54                                   ` Johannes Schindelin [this message]
2007-12-02  2:55                                   ` [PATCH 3/3] Introduce execv_git_builtin() and use it Johannes Schindelin
2007-12-02  3:04                                     ` Johannes Schindelin
2007-12-02  3:16                                       ` [REPLACEMENT PATCH " Johannes Schindelin
2007-12-02  5:19                                   ` [PATCH 0/3] Call builtin functions directly, was Re: [PATCH] transport.c: call dash-less form of receive-pack and upload-pack on remote Junio C Hamano
2007-12-02 11:35                                     ` Johannes Schindelin
2007-11-30 12:19                     ` [PATCH] Move all dashed form git commands to libexecdir Nguyen Thai Ngoc Duy
2007-11-30 13:35                       ` Johannes Schindelin
2007-11-29 15:08             ` Jeff King
2007-11-29 20:05               ` Nguyen Thai Ngoc Duy
2007-11-29 21:14                 ` Jeff King
2007-11-29 22:19                   ` Johannes Schindelin
2007-11-29 23:14                     ` Jeff King
2007-11-29 23:30                       ` Linus Torvalds
2007-11-30  0:13                         ` Junio C Hamano
2007-11-30  0:35                           ` Jeff King
2007-11-30  0:49                             ` Junio C Hamano
2007-11-30  0:58                               ` Jeff King
2007-11-30  1:13                                 ` Nicolas Pitre
2007-11-30  1:17                                   ` Jeff King
2007-11-30  5:42                                     ` Steffen Prohaska
2007-11-30  7:18                                     ` Andreas Ericsson
2007-11-30 15:09                                       ` Jeff King
2007-11-30 20:01                                         ` Junio C Hamano
2007-11-30 21:25                                           ` Jeff King
2007-11-30 23:10                                             ` Johannes Schindelin
2007-12-02 15:02                                               ` Wincent Colaiuta
2007-12-02 16:39                                                 ` Johannes Schindelin
2007-12-02 16:56                                                   ` Pascal Obry
2007-12-02 17:23                                                     ` Johannes Schindelin
2007-12-01  2:37                                             ` Junio C Hamano
2007-12-01  4:17                                               ` Jeff King
2007-11-30  2:29                                 ` Linus Torvalds
2007-11-30  2:55                                   ` Nicolas Pitre
2007-11-30  5:51                                   ` Steffen Prohaska
2007-11-30 15:12                                     ` Jeff King
2007-11-30 15:28                                       ` Santi Béjar
2007-11-30 15:29                                         ` Jeff King
2007-11-30 15:50                                           ` Linus Torvalds
2007-11-30 16:22                                             ` Jeff King
2007-11-30 18:28                                               ` Johannes Schindelin
2007-11-30 18:37                                                 ` Jeff King
2007-11-30 23:05                                                   ` Johannes Schindelin
2007-11-30 23:21                                                     ` Jeff King
2007-11-30 23:38                                                       ` Johannes Schindelin
     [not found]                                             ` <fcaeb9bf0711302234l32460a1fqbf9825fc8055f99d@mail.gmail.com>
2007-12-01 19:32                                               ` Junio C Hamano
2007-12-01 21:26                                                 ` Jeff King
2007-12-02  5:50                                                 ` Nguyen Thai Ngoc Duy
2007-11-30  0:52                             ` Nicolas Pitre
2007-11-30  1:00                               ` Jeff King
2007-11-30  1:19                                 ` Nicolas Pitre
2007-11-30  1:25                                   ` Jeff King
2007-11-30  1:33                                     ` Nicolas Pitre
2007-11-30  1:53                                       ` Jeff King
2007-11-30  2:23                                         ` A Large Angry SCM
2007-11-30  0:40                           ` Nguyen Thai Ngoc Duy
2007-11-30  0:51                           ` A Large Angry SCM
2007-11-30  0:54                             ` Johannes Schindelin
2007-11-30  2:03                               ` A Large Angry SCM
2007-11-30  1:01                             ` Nicolas Pitre
2007-11-30  2:17                               ` A Large Angry SCM
2007-11-30  2:27                                 ` Nicolas Pitre
2007-11-29  0:14           ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0712020254370.27959@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=bulb@ucw.cz \
    --cc=eyvind-git-list@orakel.ntnu.no \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).