From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] Avoid double exec() in execv_git_cmd()
Date: Sun, 2 Dec 2007 12:24:20 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712021221410.27959@racer.site> (raw)
In-Reply-To: <1196579005-5662-2-git-send-email-gitster@pobox.com>
Hi,
On Sat, 1 Dec 2007, Junio C Hamano wrote:
> This avoids double exec() when execv_git_cmd() is used to spawn an
> external git command.
>
> For this, execv_git_cmd() needs to be able to tell what's built-in.
> This is done by introducing a new function git_builtin_command() that
> checks the list of built-in commands and returns a pointer to the
> cmd_struct if found. The same function is used from the git potty.
IMNSHO this does not buy us anything, compared to my patch series. Your
patch is larger, distributes the responsibility for the builtins to two
files instead of one, and since we control what is builtin and what not,
is not really less fragile with respect to what needs to be initialised.
Besides, we lose a great opportunity to go in the direction of
libification.
Ciao,
Dscho
next prev parent reply other threads:[~2007-12-02 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 7:03 [PATCH 1/3] Prepare execv_git_cmd() for removal of builtins from the filesystem Junio C Hamano
2007-12-02 7:03 ` [PATCH 2/3] Avoid double exec() in execv_git_cmd() Junio C Hamano
2007-12-02 7:03 ` [PATCH 3/3] git-shell: accept "git foo" form Junio C Hamano
2007-12-02 12:24 ` Johannes Schindelin [this message]
2007-12-02 8:48 ` [PATCH 1/3] Prepare execv_git_cmd() for removal of builtins from the filesystem Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712021221410.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).