From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Anatol Pomozov <anatol.pomozov@gmail.com>,
git@vger.kernel.org
Subject: Re: Incorrect git-blame result if I use full path to file
Date: Mon, 3 Dec 2007 18:09:05 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712031807410.27959@racer.site> (raw)
In-Reply-To: <alpine.LFD.0.9999.0712030922250.8458@woody.linux-foundation.org>
Hi,
On Mon, 3 Dec 2007, Linus Torvalds wrote:
> It [the patch] makes "get_pathspec()" make all the paths it returns
> relative, if it can. HOWEVER! I think it should actually die() if it
> sees an absolute path that it cannot convert (because it really cannot
> do anything sane about it), but I commented that out for now because
> that requires some test case change: right now we actually have a few
> test cases for insane filename arguments, and they expect the old
> behaviour.
I have the slight suspicion that this could break diff --no-index. And it
does not contain any symlink resolution, right?
Ciao,
Dscho
next prev parent reply other threads:[~2007-12-03 18:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 0:52 Incorrect git-blame result if I use full path to file Anatol Pomozov
2007-12-03 2:19 ` Junio C Hamano
2007-12-03 2:28 ` Jeff King
2007-12-03 17:26 ` Linus Torvalds
2007-12-03 18:09 ` Johannes Schindelin [this message]
2007-12-03 18:13 ` Linus Torvalds
2007-12-03 18:19 ` Linus Torvalds
2007-12-03 2:27 ` Jeff King
2007-12-03 2:40 ` Junio C Hamano
2007-12-03 2:49 ` Jeff King
2007-12-03 6:55 ` Robin Rosenberg
2007-12-03 20:53 ` [PATCH] Make Git accept absolute path names for files within the work tree Robin Rosenberg
2007-12-03 23:03 ` Junio C Hamano
2007-12-04 1:43 ` Jeff King
2007-12-04 2:17 ` Johannes Schindelin
2007-12-04 6:42 ` Robin Rosenberg
2007-12-04 11:50 ` Johannes Schindelin
2007-12-04 15:59 ` Linus Torvalds
2007-12-04 22:08 ` Jeff King
2007-12-04 22:52 ` Linus Torvalds
2007-12-06 6:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712031807410.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=anatol.pomozov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).