From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] Simplify crud() in ident.c
Date: Mon, 3 Dec 2007 20:47:09 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712032046480.27959@racer.site> (raw)
In-Reply-To: <20071203191143.GB17671@steel.home>
Hi,
On Mon, 3 Dec 2007, Alex Riesen wrote:
> diff --git a/ident.c b/ident.c
> index 9b2a852..dbd0f52 100644
> --- a/ident.c
> +++ b/ident.c
> @@ -113,25 +113,15 @@ static int add_raw(char *buf, size_t size, int offset, const char *str)
>
> static int crud(unsigned char c)
> {
> - static char crud_array[256];
> - static int crud_array_initialized = 0;
> -
> - if (!crud_array_initialized) {
> - int k;
> -
> - for (k = 0; k <= 31; ++k) crud_array[k] = 1;
> - crud_array[' '] = 1;
> - crud_array['.'] = 1;
> - crud_array[','] = 1;
> - crud_array[':'] = 1;
> - crud_array[';'] = 1;
> - crud_array['<'] = 1;
> - crud_array['>'] = 1;
> - crud_array['"'] = 1;
> - crud_array['\''] = 1;
> - crud_array_initialized = 1;
> - }
> - return crud_array[c];
> + return c <= 32 ||
> + c == '.' ||
> + c == ',' ||
> + c == ':' ||
> + c == ';' ||
> + c == '<' ||
> + c == '>' ||
> + c == '"' ||
> + c == '\'';
Or enhance ctype.c.
Ciao,
Dscho
next prev parent reply other threads:[~2007-12-03 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 19:11 [PATCH] Simplify crud() in ident.c Alex Riesen
2007-12-03 20:19 ` Jakub Narebski
2007-12-03 21:32 ` Alex Riesen
2007-12-03 22:55 ` Luke Lu
2007-12-03 20:47 ` Johannes Schindelin [this message]
2007-12-03 21:37 ` Alex Riesen
2007-12-03 22:48 ` Johannes Schindelin
2007-12-03 22:52 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712032046480.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).