From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Allow ':/<oneline-prefix>' syntax to work with save_commit_buffer == 0
Date: Mon, 3 Dec 2007 22:52:21 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712032249260.27959@racer.site> (raw)
In-Reply-To: <7vhcizh38y.fsf@gitster.siamese.dyndns.org>
Hi,
On Mon, 3 Dec 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > On Mon, 3 Dec 2007, Jeff King wrote:
> >
> > > On Mon, Dec 03, 2007 at 10:55:15AM +0000, Johannes Schindelin wrote:
> > >
> > > > But then, my patch also works when save_commit_buffer == 0.
> > > > But I can refactor this into its own patch, since it really is
> > > > a separate issue.
> > >
> > > Agreed.
> >
> > Here we go.
>
> The log message is a bit lacking. I would have expected "git-show
> command can take ':/prefix' as an argument to name a commit whose
> subject begins with the prefix, but git-foobar command didn't and
> instead errored out. This fixes it so that ':/prefix' syntax can be
> used for any command that wants to take a commit object name".
Sorry. Can I ask you to amend the commit message with this?
-- snip --
Earlier, ':/<oneline-prefix>' would not work (i.e. die) with commands that
set save_commit_buffer = 0, such as blame, describe, pack-objects, reflog
and bundle.
Fix this.
-- snap --
Thanks,
Dscho
prev parent reply other threads:[~2007-12-03 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 4:32 [PATCH/RFC] Use regex for :/ matching Jeff King
2007-12-03 10:55 ` Johannes Schindelin
2007-12-03 17:30 ` Jeff King
2007-12-03 18:17 ` Junio C Hamano
2007-12-06 5:52 ` Jeff King
2007-12-06 6:33 ` Junio C Hamano
2007-12-06 6:39 ` Jeff King
2007-12-06 12:13 ` Johannes Schindelin
2007-12-03 18:42 ` [PATCH] Allow ':/<oneline-prefix>' syntax to work with save_commit_buffer == 0 Johannes Schindelin
2007-12-03 21:34 ` Junio C Hamano
2007-12-03 22:52 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712032249260.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).