From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] Use regex for :/ matching
Date: Thu, 6 Dec 2007 12:13:37 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712061212590.27959@racer.site> (raw)
In-Reply-To: <20071206063945.GB18698@coredump.intra.peff.net>
Hi,
On Thu, 6 Dec 2007, Jeff King wrote:
> On Wed, Dec 05, 2007 at 10:33:49PM -0800, Junio C Hamano wrote:
>
> > Making what was string match to regex using the same syntax is a
> > regression, isn't it? I do not use :/ very often myself, so I
> > personally would not mind but people who are used to using :/ may get
> > upset about the change. I do not feel strongly enough for changing it
> > to regex to declare such a change unilaterally.
>
> Yes, it is a regression, which is why my initial patch was labeled RFC.
> Nobody commented on that aspect, [...]
I did. I sent a link to my own version of that patch, thereby displaying
my agreement with the intent.
Ciao,
Dscho
next prev parent reply other threads:[~2007-12-06 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 4:32 [PATCH/RFC] Use regex for :/ matching Jeff King
2007-12-03 10:55 ` Johannes Schindelin
2007-12-03 17:30 ` Jeff King
2007-12-03 18:17 ` Junio C Hamano
2007-12-06 5:52 ` Jeff King
2007-12-06 6:33 ` Junio C Hamano
2007-12-06 6:39 ` Jeff King
2007-12-06 12:13 ` Johannes Schindelin [this message]
2007-12-03 18:42 ` [PATCH] Allow ':/<oneline-prefix>' syntax to work with save_commit_buffer == 0 Johannes Schindelin
2007-12-03 21:34 ` Junio C Hamano
2007-12-03 22:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712061212590.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).