git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Miller <davem@davemloft.net>
Cc: gitster@pobox.com, raa.lkml@gmail.com, git@vger.kernel.org
Subject: Re: testsuite failures in mainline...
Date: Sat, 15 Dec 2007 01:18:59 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0712150117330.27959@racer.site> (raw)
In-Reply-To: <20071214.160845.185161708.davem@davemloft.net>

Hi,

On Fri, 14 Dec 2007, David Miller wrote:

> -	char space[FLEX_ARRAY]; /* more */
> +	uintmax_t space[FLEX_ARRAY]; /* more */

Usually, a much better idea is to use

	union {
		char cp[FLEX_ARRAY];
		uintmax_t up[FLEX_ARRAY];
	}

because that is exactly the reason union was invented for.

Ciao,
Dscho

      reply	other threads:[~2007-12-15  1:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 18:43 testsuite failures in mainline David Miller
2007-12-14 19:15 ` Junio C Hamano
2007-12-14 19:17   ` David Miller
2007-12-14 20:10     ` Junio C Hamano
2007-12-14 21:45     ` Alex Riesen
2007-12-14 22:24       ` David Miller
2007-12-14 23:18         ` Junio C Hamano
2007-12-15  0:08           ` David Miller
2007-12-15  1:18             ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0712150117330.27959@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=davem@davemloft.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).