git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Steven Grimm <koreth@midwinter.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow commit (and tag) messages to be edited when $EDITOR has arguments
Date: Sun, 16 Dec 2007 01:41:20 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0712160139580.27959@racer.site> (raw)
In-Reply-To: <20071216011201.GA10867@midwinter.com>

Hi,

On Sat, 15 Dec 2007, Steven Grimm wrote:

> 	Looked around but didn't see an existing "build a char* array
> 	out of a delimited string" function in the git source; if one
> 	exists, of course it should be used instead of my pair of loops
> 	here.

Did you look for split_cmdline() in git.c?  IMHO it should move to 
run-command.c and be made public.

Thanks,
Dscho

  reply	other threads:[~2007-12-16  1:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16  1:12 [PATCH] Allow commit (and tag) messages to be edited when $EDITOR has arguments Steven Grimm
2007-12-16  1:41 ` Johannes Schindelin [this message]
2007-12-16  7:34   ` [PATCH v2] " Steven Grimm
2007-12-16 15:36     ` Johannes Schindelin
2007-12-16  1:41 ` [PATCH] " Thomas Harning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0712160139580.27959@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=koreth@midwinter.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).