From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Kelvie Wong <kelvie@ieee.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add an "-i" option to git-reset, to confirm a reset.
Date: Sun, 16 Dec 2007 03:35:09 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712160332140.27959@racer.site> (raw)
In-Reply-To: <1197775596-14329-1-git-send-email-kelvie@ieee.org>
Hi,
On Sat, 15 Dec 2007, Kelvie Wong wrote:
> It shows a diffstat, and asks the user if they would like to continue,
> or show a full diff of the things getting reset.
>
> I know that many times, I do a reset --hard thinking I had commited a
> file already, but it turns out that I hadn't; and so this makes sure I
> don't lose any work when the caffeine wears off.
>
> Maybe it should also be made that only hard resets take this option, as
> I cannot see this being useful in other places.
I am slightly negative on this patch. Not only do I think that it is both
easier and more natural to run diff/status/an-alias to see what a reset
would do, but the patch only handles the index_file part (missing the --
<file> part AFAICT).
Besides, the code style is incompatible with the surrounding code.
Ciao,
Dscho
next prev parent reply other threads:[~2007-12-16 3:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 3:26 [PATCH] Add an "-i" option to git-reset, to confirm a reset Kelvie Wong
2007-12-16 3:35 ` Johannes Schindelin [this message]
2007-12-16 3:46 ` Kelvie Wong
2007-12-16 20:09 ` Junio C Hamano
2007-12-16 21:26 ` Kelvie Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712160332140.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kelvie@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).