From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Wincent Colaiuta <win@wincent.com>
Cc: Pierre Habouzit <madcoder@debian.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Have a flag to stop the option parsing at the first argument.
Date: Mon, 17 Dec 2007 12:26:39 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712171223210.9446@racer.site> (raw)
In-Reply-To: <3CF3CEA5-72F1-47D1-ADB9-37F5C2E292A8@wincent.com>
Hi,
On Mon, 17 Dec 2007, Wincent Colaiuta wrote:
> Yes, we know what it does because we know that "git ... log ..." is
> actually two commands and each one handles one of the -p switches, but
> it is much easier to present git as a single tool to the newcomer (and I
> guess I don't need to argue that case here seeing as the decision has
> already been taken long ago to talk using dashless forms), and it is
> much easier to explain to a newcomer something like:
>
> git log --paginate -p
>
> Than:
>
> git -p log -p
How about
git log -p
Hmm?
Fact is: you make the tool easier by having sane defaults. Not by moving
around command line options. The option "-p" for git is an option that
holds for _all_ subcommands. That's why it belongs _before_ the
subcommand.
> But it doesn't really matter. The proposed changes allow old-timers to
> continue putting their special options between the "git" and the
> "command". If you don't want to deprecate the -p special because of the
> confusion it might cause, I think we should at least not give it a very
> prominent place in the documentation, nor use it any examples.
I think it is wrong to go out of our way to support "git status -p" as a
synonym to "git -p status". I simply do not believe that newcomers are
not intelligent enough to understand that "git -p <subcommand>" means that
the output goes into their pager.
Ciao,
Dscho
next prev parent reply other threads:[~2007-12-17 12:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 11:23 [PATCH 0/3] diff topic tweaks Wincent Colaiuta
2007-12-14 11:23 ` [PATCH 1/3] Revert changes and extend diff option documentation Wincent Colaiuta
2007-12-14 11:23 ` [PATCH 2/3] Use shorter error messages for whitespace problems Wincent Colaiuta
2007-12-14 11:23 ` [PATCH 3/3] Test interaction between diff --check and --exit-code Wincent Colaiuta
2007-12-16 19:43 ` [PATCH 1/3] Revert changes and extend diff option documentation Junio C Hamano
2007-12-17 8:27 ` git.c option parsing (was: [PATCH 1/3] Revert changes and extend diff option documentation) Wincent Colaiuta
2007-12-17 8:48 ` git.c option parsing Junio C Hamano
2007-12-17 9:01 ` Wincent Colaiuta
2007-12-17 9:20 ` Pierre Habouzit
2007-12-17 9:26 ` Pierre Habouzit
2007-12-17 9:50 ` [PATCH] Have a flag to stop the option parsing at the first argument Pierre Habouzit
2007-12-17 10:34 ` Johannes Schindelin
2007-12-17 11:10 ` Wincent Colaiuta
2007-12-17 11:47 ` Pierre Habouzit
2007-12-17 11:50 ` Johannes Schindelin
2007-12-17 12:06 ` Wincent Colaiuta
2007-12-17 12:26 ` Johannes Schindelin [this message]
2007-12-17 12:40 ` Wincent Colaiuta
2007-12-17 12:55 ` Johannes Schindelin
2007-12-17 13:12 ` Wincent Colaiuta
2007-12-17 13:30 ` Johannes Schindelin
2007-12-17 13:57 ` Wincent Colaiuta
2007-12-17 15:13 ` Johannes Sixt
2007-12-17 16:29 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712171223210.9446@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).